You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Maja Kabiljo <ma...@fb.com> on 2013/07/15 22:56:17 UTC
Review Request 12559: GIRAPH-716: Stop modifying Configuration since it's
not thread-safe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12559/
-----------------------------------------------------------
Review request for giraph.
Bugs: GIRAPH-716
https://issues.apache.org/jira/browse/GIRAPH-716
Repository: giraph-git
Description
-------
It seems GIRAPH-694 wasn't enough, since we got similar problems again. We should not modify Configurations, but create copies when we need them. There were some issues in hive-io which prevented us from doing this in the first place, which are fixed now.
Diffs
-----
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 74f1ba5
giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeInputFormat.java c3adf4c
giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeReader.java e3b3689
giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexInputFormat.java a58a32d
giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexOutputFormat.java bffa330
giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexReader.java bf0a212
giraph-core/src/main/java/org/apache/giraph/job/HadoopUtils.java d5095bc
pom.xml 7a79aed
Diff: https://reviews.apache.org/r/12559/diff/
Testing
-------
Passes 'mvn clean verify' (also with hadoop_2.0.0 profile). Passed real job on the cluster with both hive-io and hcatalog.
Thanks,
Maja Kabiljo
Re: Review Request 12559: GIRAPH-716: Stop modifying Configuration since
it's not thread-safe
Posted by Maja Kabiljo <ma...@fb.com>.
> On July 15, 2013, 9:14 p.m., Avery Ching wrote:
> > +1, this is awesome, much better than hacky/incoreect GIRAPH-694.
Thanks for a quick review! My original solution was hacky, 694 was a nice try :-)
- Maja
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12559/#review23172
-----------------------------------------------------------
On July 15, 2013, 8:56 p.m., Maja Kabiljo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12559/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 8:56 p.m.)
>
>
> Review request for giraph.
>
>
> Bugs: GIRAPH-716
> https://issues.apache.org/jira/browse/GIRAPH-716
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> It seems GIRAPH-694 wasn't enough, since we got similar problems again. We should not modify Configurations, but create copies when we need them. There were some issues in hive-io which prevented us from doing this in the first place, which are fixed now.
>
>
> Diffs
> -----
>
> giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 74f1ba5
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeInputFormat.java c3adf4c
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeReader.java e3b3689
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexInputFormat.java a58a32d
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexOutputFormat.java bffa330
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexReader.java bf0a212
> giraph-core/src/main/java/org/apache/giraph/job/HadoopUtils.java d5095bc
> pom.xml 7a79aed
>
> Diff: https://reviews.apache.org/r/12559/diff/
>
>
> Testing
> -------
>
> Passes 'mvn clean verify' (also with hadoop_2.0.0 profile). Passed real job on the cluster with both hive-io and hcatalog.
>
>
> Thanks,
>
> Maja Kabiljo
>
>
Re: Review Request 12559: GIRAPH-716: Stop modifying Configuration since
it's not thread-safe
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12559/#review23172
-----------------------------------------------------------
Ship it!
+1, this is awesome, much better than hacky/incoreect GIRAPH-694.
- Avery Ching
On July 15, 2013, 8:56 p.m., Maja Kabiljo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12559/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 8:56 p.m.)
>
>
> Review request for giraph.
>
>
> Bugs: GIRAPH-716
> https://issues.apache.org/jira/browse/GIRAPH-716
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> It seems GIRAPH-694 wasn't enough, since we got similar problems again. We should not modify Configurations, but create copies when we need them. There were some issues in hive-io which prevented us from doing this in the first place, which are fixed now.
>
>
> Diffs
> -----
>
> giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 74f1ba5
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeInputFormat.java c3adf4c
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeReader.java e3b3689
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexInputFormat.java a58a32d
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexOutputFormat.java bffa330
> giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexReader.java bf0a212
> giraph-core/src/main/java/org/apache/giraph/job/HadoopUtils.java d5095bc
> pom.xml 7a79aed
>
> Diff: https://reviews.apache.org/r/12559/diff/
>
>
> Testing
> -------
>
> Passes 'mvn clean verify' (also with hadoop_2.0.0 profile). Passed real job on the cluster with both hive-io and hcatalog.
>
>
> Thanks,
>
> Maja Kabiljo
>
>