You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2017/04/19 22:45:54 UTC

[GitHub] beam pull request #2601: [BEAM-1414] Replaces CountingInput with style guide...

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/2601

    [BEAM-1414] Replaces CountingInput with style guide compliant GenerateSequence

    Migration guide:
    `CountingInput.unbounded()` -> `GenerateSequence.from(0)`
    `CountingInput.upTo(n)` -> `GenerateSequence.fromTo(0, n)`
    
    Removing rogue direct uses of CountingSource is for another PR and less critical.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam count-style

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2601
    
----
commit d0d97f165d954471ae2e693efea5d65e44dfaaa2
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-18T23:48:38Z

    Introduces GenerateSequence transform
    
    It is a replacement for CountingInput, which will be deprecated.

commit 8199c5fb65807e062854952720d6dc2a751c1e56
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-19T22:32:08Z

    Replaces all usages of CountingInput with GenerateSequence

commit 767af74f9d7105e25872aad873c3c70fe87f741c
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-19T22:36:42Z

    Deletes CountingInput

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2601: [BEAM-1414] Replaces CountingInput with style guide...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2601


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---