You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/04/21 14:30:15 UTC
[GitHub] [singa] joddiy opened a new pull request #684: ONNX supports module
joddiy opened a new pull request #684:
URL: https://github.com/apache/singa/pull/684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on issue #684: ONNX supports module
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #684:
URL: https://github.com/apache/singa/pull/684#issuecomment-617729264
This pull request **introduces 5 alerts** when merging a4defbfa38ee21f41765554b725500606a83a666 into 893992c30baaf64fc796feebb468887c7cdfd117 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-55a8e5b24facc190ff3e7ea8f8a31d65cc17ef8c)
**new alerts:**
* 3 for Unreachable code
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #684: ONNX supports module
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #684:
URL: https://github.com/apache/singa/pull/684#issuecomment-619850181
This pull request **introduces 5 alerts** when merging bfa262bceefcf875905e2bd666f183e9906edfdd into 893992c30baaf64fc796feebb468887c7cdfd117 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-dc6fae4076d63db2f953f1bf03547fd5366a320d)
**new alerts:**
* 3 for Unreachable code
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] XJDKC commented on a change in pull request #684: ONNX supports module
Posted by GitBox <gi...@apache.org>.
XJDKC commented on a change in pull request #684:
URL: https://github.com/apache/singa/pull/684#discussion_r416846262
##########
File path: python/singa/sonnx.py
##########
@@ -2135,6 +2084,81 @@ def run(self, inputs, **kwargs):
return [ret_outputs[outp] for outp in final_outputs]
+class BaseModel(module.Module):
+
+ def __init__(self, sg_ir, loss, optimizer):
+ """
+ Init a SIGNA Module
+ Args:
+ sg_ir: a SingaRep class
+ """
+ super(BaseModel, self).__init__()
+ self.optimizer = optimizer
+ self.loss = loss
Review comment:
Please change the name of this member variable. Since loss is already the name of a member function, this assignment will rewrite the original function. So the loss function is not wrapped by the decorator(buffer_operation) which will cause a new operation to be created in each iteration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] joddiy closed pull request #684: ONNX supports module
Posted by GitBox <gi...@apache.org>.
joddiy closed pull request #684:
URL: https://github.com/apache/singa/pull/684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org