You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/11 12:34:00 UTC

[GitHub] [spark] MaxGekk opened a new pull request #25116: [SPARK-26978][SQL][FOLLOWUP] Initialize date-time constants by foldable expressions

MaxGekk opened a new pull request #25116: [SPARK-26978][SQL][FOLLOWUP] Initialize date-time constants by foldable expressions
URL: https://github.com/apache/spark/pull/25116
 
 
   ## What changes were proposed in this pull request?
   
   Reverted initialization of date-time constants in `DateTimeUtils` introduced by #23878. As a comment in [Delta repo](https://github.com/delta-io/delta) states, the compiler can do additional optimizations if values can be calculated at compile time: https://github.com/delta-io/delta/blob/master/src/main/scala/org/apache/spark/sql/delta/util/DateTimeUtils.scala#L63-L75 
   
   ## How was this patch tested?
   
   This was tested by existing test suites.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org