You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/10/30 16:58:02 UTC
[kudu-CR](branch-1.18.x) KUDU-3589 Wait until masters become voters
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21996
Change subject: KUDU-3589 Wait until masters become voters
......................................................................
KUDU-3589 Wait until masters become voters
In SecurityITest.TestNonDefaultPrincipalMultipleMaster test, when the
leader was shut down, it was possible that some of the Raft members
are still in learner mode. This makes it impossible for the cluster to
recover and elect a new leader. To solve this test issue, there is an
explicit wait until masters become voters in the Raft consensus. This
was done by using the already existing VerifyVotersOnAllMasters
function. The function was moved from dynamic_multi_master-test to
external_mini_cluster to be usable from security-itest, too.
Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Reviewed-on: http://gerrit.cloudera.org:8080/21636
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit c5993dbf4f8e706784c690f3d5b38cad75276387)
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
4 files changed, 46 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/21996/1
--
To view, visit http://gerrit.cloudera.org:8080/21996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Gerrit-Change-Number: 21996
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR](branch-1.18.x) KUDU-3589 Wait until masters become voters
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21996 )
Change subject: KUDU-3589 Wait until masters become voters
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Gerrit-Change-Number: 21996
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2024 00:36:28 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3589 Wait until masters become voters
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21996 )
Change subject: KUDU-3589 Wait until masters become voters
......................................................................
KUDU-3589 Wait until masters become voters
In SecurityITest.TestNonDefaultPrincipalMultipleMaster test, when the
leader was shut down, it was possible that some of the Raft members
are still in learner mode. This makes it impossible for the cluster to
recover and elect a new leader. To solve this test issue, there is an
explicit wait until masters become voters in the Raft consensus. This
was done by using the already existing VerifyVotersOnAllMasters
function. The function was moved from dynamic_multi_master-test to
external_mini_cluster to be usable from security-itest, too.
Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Reviewed-on: http://gerrit.cloudera.org:8080/21636
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit c5993dbf4f8e706784c690f3d5b38cad75276387)
Reviewed-on: http://gerrit.cloudera.org:8080/21996
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
4 files changed, 46 insertions(+), 36 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Gerrit-Change-Number: 21996
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR](branch-1.18.x) KUDU-3589 Wait until masters become voters
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21996 )
Change subject: KUDU-3589 Wait until masters become voters
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/630/
--
To view, visit http://gerrit.cloudera.org:8080/21996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Gerrit-Change-Number: 21996
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 16:58:09 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3589 Wait until masters become voters
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3589 Wait until masters become voters
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Gerrit-Change-Number: 21996
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR](branch-1.18.x) KUDU-3589 Wait until masters become voters
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21996 )
Change subject: KUDU-3589 Wait until masters become voters
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/630/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Gerrit-Change-Number: 21996
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 18:48:07 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3589 Wait until masters become voters
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21996 )
Change subject: KUDU-3589 Wait until masters become voters
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ea46345680ce506206e9335a147b887fc173b50
Gerrit-Change-Number: 21996
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2024 00:32:02 +0000
Gerrit-HasComments: No