You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/29 23:05:17 UTC
[GitHub] [incubator-superset] bkyryliuk opened a new pull request #11110: fix: fix alembic migration
bkyryliuk opened a new pull request #11110:
URL: https://github.com/apache/incubator-superset/pull/11110
### SUMMARY
Fixes the order of the migrations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #11110: fix: fix alembic migration
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #11110:
URL: https://github.com/apache/incubator-superset/pull/11110#issuecomment-701038518
> Thanks for the quick fix!
>
> I wonder if there's a way in the future to require PRs that touch the migrations directory to be rebased before merging. We wouldn't want to do this for all PRs, but it might be nice for these specifically
I think we had a separate CI test for it could be that I just have a bad memory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk merged pull request #11110: fix: fix alembic migration
Posted by GitBox <gi...@apache.org>.
bkyryliuk merged pull request #11110:
URL: https://github.com/apache/incubator-superset/pull/11110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #11110: fix: fix alembic migration
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #11110:
URL: https://github.com/apache/incubator-superset/pull/11110#issuecomment-701038039
Thanks for the quick fix!
I wonder if there's a way in the future to require PRs that touch the migrations directory to be rebased before merging. We wouldn't want to do this for all PRs, but it might be nice for these specifically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org