[jira] Commented: (CASSANDRA-184) intermittent OneCompactionTest failure

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710445#action_12710445 ] 

Jun Rao commented on CASSANDRA-184:
-----------------------------------

The patch looks fine to me. 

The following comment in CFS.storeLocation() confuses me:
        /* it's ok if compaction gets submitted multiple times while one is already in process.
           worst that happens is, compactor will count the sstable files and decide there are
           not enough to bother with. */

With this patch, there can't be mutiple ongoing compactions, right?


> intermittent OneCompactionTest failure
> --------------------------------------
>
>                 Key: CASSANDRA-184
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-184
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.3
>            Reporter: Jonathan Ellis
>         Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError                                              
>     [junit]     at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)                   
>     [junit]     at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
>     [junit]     at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)     
>     [junit]     at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)    
>     [junit]     at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.