You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/16 12:30:30 UTC
[GitHub] [incubator-mxnet] hubutui opened a new issue #17845: openmp in
CMakeLists.txt needs to be updated
hubutui opened a new issue #17845: openmp in CMakeLists.txt needs to be updated
URL: https://github.com/apache/incubator-mxnet/issues/17845
Currently, cmake check if `${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/openmp/CMakeLists.txt` exists, check [here](https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L430), then build openmp from source, which is always true, and cmake will never use openmp provided in system, check [here](https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L444) . So these codes need to to reordered. Another issue, the minimum cmake version is 3.13, and according to cmake [doc](https://cmake.org/cmake/help/v3.13/module/FindOpenMP.html), `OpenMP_FOUND` is used, not `OPENMP_FOUND`, this [line](https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L446) needs to be updated, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] cjolivier01 commented on issue #17845: openmp in
CMakeLists.txt needs to be updated
Posted by GitBox <gi...@apache.org>.
cjolivier01 commented on issue #17845: openmp in CMakeLists.txt needs to be updated
URL: https://github.com/apache/incubator-mxnet/issues/17845#issuecomment-599706581
Just remove openmp entirely. I don’t care anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17845: openmp in
CMakeLists.txt needs to be updated
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17845: openmp in CMakeLists.txt needs to be updated
URL: https://github.com/apache/incubator-mxnet/issues/17845#issuecomment-599684343
`OPENMP_FOUND` is provided by cmake for backwards compatibility and also works.
@cjolivier01 has a veto on enabling users to use system openmp. You need to manually delete `3rdparty/openmp` or modify `CMakeLists.txt` to use system openmp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hubutui commented on issue #17845: openmp in
CMakeLists.txt needs to be updated
Posted by GitBox <gi...@apache.org>.
hubutui commented on issue #17845: openmp in CMakeLists.txt needs to be updated
URL: https://github.com/apache/incubator-mxnet/issues/17845#issuecomment-599857170
Yeah, I know I could remove `3rdparty/openmp`, and that's what I do for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services