svn commit: r1882047 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java

[le...@apache.org]

Author: lehmi
Date: Sat Sep 26 16:25:06 2020
New Revision: 1882047

URL: http://svn.apache.org/viewvc?rev=1882047&view=rev
Log:
PDFBOX-4956: make maps final, fix hashcode initialization as proposed by Jörg Waßmer

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java?rev=1882047&r1=1882046&r2=1882047&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSName.java Sat Sep 26 16:25:06 2020
@@ -33,11 +33,11 @@ import org.apache.pdfbox.util.Hex;
 public final class COSName extends COSBase implements Comparable<COSName>
 {
     // using ConcurrentHashMap because this can be accessed by multiple threads
-    private static Map<String, COSName> nameMap = new ConcurrentHashMap<>(8192);
+    private static final Map<String, COSName> nameMap = new ConcurrentHashMap<>(8192);
 
     // all common COSName values are stored in this HashMap
     // they are already defined as static constants and don't need to be synchronized
-    private static Map<String, COSName> commonNameMap = new HashMap<>(768);
+    private static final Map<String, COSName> commonNameMap = new HashMap<>(768);
 
     //
     // IMPORTANT: this list is *alphabetized* and does not need any JavaDoc
@@ -650,6 +650,7 @@ public final class COSName extends COSBa
     private COSName(String aName, boolean staticValue)
     {
         name = aName;
+        hashCode = name.hashCode();
         if (staticValue)
         {
             commonNameMap.put(aName, this);
@@ -658,7 +659,6 @@ public final class COSName extends COSBa
         {
             nameMap.put(aName, this);
         }
-        hashCode = name.hashCode();
     }
 
     /**