You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/01/29 13:49:55 UTC

[PR] HDDS-12155. Create new submodule for ozone shell [ozone]

adoroszlai opened a new pull request, #7775:
URL: https://github.com/apache/ozone/pull/7775

   ## What changes were proposed in this pull request?
   
   `ozone-tools` depends on server-side components (OM, SCM, Recon, etc.).  These are needed for some of the tools, e.g. `ozone debug`, `ozone repair`, but not for `ozone shell`.
   
   This PR splits `ozone shell` into a new submodule `ozone-cli-shell`, with client-only dependencies.  (We can split sets of tools into other `ozone-cli-...` modules later.)
   
   `pom.xml` is copied from `hadoop-ozone/tools`, with unnecessary dependencies removed.
   
   https://issues.apache.org/jira/browse/HDDS-12155
   
   ## How was this patch tested?
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/13031228751


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12155. Create new submodule for ozone shell [ozone]

Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #7775:
URL: https://github.com/apache/ozone/pull/7775#issuecomment-2623666727

   Thanks @adoroszlai for the contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12155. Create new submodule for ozone shell [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7775:
URL: https://github.com/apache/ozone/pull/7775#issuecomment-2623667307

   Thanks @nandakumar131 for reviewing and merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12155. Create new submodule for ozone shell [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7775:
URL: https://github.com/apache/ozone/pull/7775#issuecomment-2623664380

   Thanks @nandakumar131 for the review.
   
   > why did we move `AbstractMixin.java` and `AbstractSubcommand.java` to `hadoop-hdds/common`?
   
   Those are the only dependencies from `hdds-tools` required by the shell.  `hdds-tools` still depends on `container-service`, which is a server-side dependency I wanted to avoid for this module.  I'll work on cleaning up that dependency separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12155. Create new submodule for ozone shell [ozone]

Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 merged PR #7775:
URL: https://github.com/apache/ozone/pull/7775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org