[GitHub] [fineract] ptuomola opened a new pull request #2014: Fixing deployment to Fineract.dev

[GitBox <gi...@apache.org>]

ptuomola opened a new pull request #2014:
URL: https://github.com/apache/fineract/pull/2014


   ## Description
   
   Describe the changes made and why they were made.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #2014: Fixing deployment to Fineract.dev

[GitBox <gi...@apache.org>]

ptuomola commented on pull request #2014:
URL: https://github.com/apache/fineract/pull/2014#issuecomment-1005238512


   @vorburger this was my attempt to fix the errors you highlighted... but unfortunately looks like this does not work: I can see from the Cloud Build Console that the builds are failing, but I can't see why - just get an error message saying "Error: Caller does not have permission" when I try to view the build logs. The step it fails is: "build -t gcr.io/vorburger-learn-appengin/fineract:develop fineract.git". I'll revert the PR to get the builds to pass again. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vidakovic merged pull request #2014: Fixing deployment to Fineract.dev

[GitBox <gi...@apache.org>]

vidakovic merged pull request #2014:
URL: https://github.com/apache/fineract/pull/2014


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org