[GitHub] [dolphinscheduler] liqingwang edited a comment on issue #7992: [Feature][Alert] Support PagerDuty Plugin && Alert module judging strategy

[GitBox <gi...@apache.org>]

liqingwang edited a comment on issue #7992:
URL: https://github.com/apache/dolphinscheduler/issues/7992#issuecomment-1015136643


   @lenboo Thanks for your reply!
   
   > Add alert_strategy in t_ds_alert table
   > According to my understanding, this field should be "process/task state"?
   
   Yes, you are right. Maybe change the COMMENT to below is more clear.
   `alert_strategy tinyint(4) NOT NULL COMMENT 'Alert strategy: 0 process/task is successfully, 1 process/task is failed'.`
   
   > When process/task finish, alert can only be triggered once, and 't_ds_alert' will only have one data about this process/task.
   
   That's right. Only one record will be inserted in 't_ds_alert' when process/task is finished. But process/task binds the alert group, and multiple instances of multiple alert methods can be created in an alert group. The design document is [here](https://github.com/apache/dolphinscheduler/issues/3049#issue-644380894). The source code is [here](https://github.com/apache/dolphinscheduler/blob/2.0.2-release/dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertSender.java#L54).
   
   > At the same time, we need to consider not only success and failure, but also others, such as pause and stop, and possible increase in the future
   
   Yes, I agree with you. And I think we can do step-by-step iterations. In the further, we can support more scenes, such as pause and stop you said, and maybe online and offline. The current architecture is supported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org