[GitHub] [spark] xuanyuanking commented on a change in pull request #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API
URL: https://github.com/apache/spark/pull/25361#discussion_r310866301
 
 

 ##########
 File path: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java
 ##########
 @@ -129,8 +129,8 @@
   @Override
   public void write(Iterator<Product2<K, V>> records) throws IOException {
     assert (partitionWriters == null);
-    ShuffleMapOutputWriter mapOutputWriter = shuffleExecutorComponents
-        .createMapOutputWriter(shuffleId, mapId, mapTaskAttemptId, numPartitions);
+    ShuffleMapOutputWriter mapOutputWriter = shuffleExecutorComponents.createMapOutputWriter(
+        shuffleId, -1, mapId, mapTaskAttemptId, numPartitions);
 
 Review comment:
   This PR created for quick reviewing of API changes, you can see the real scenario of shuffleGeneraionId here :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org