You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/03 20:56:15 UTC
[PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
pjfanning opened a new pull request, #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126
see https://github.com/apache/incubator-pekko-site/issues/95
needs more testing before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#discussion_r1510511451
##########
theme/src/main/assets/page.st:
##########
@@ -46,7 +46,7 @@ $!
$ elseif (page.properties.("material.author")) $
<meta name="author" content="$page.properties.("site.author")$">
$ endif $
- <link rel="shortcut icon" href="$page.base$$page.properties.("material.favicon")$">
+ <link rel="shortcut icon" href="$page.properties.("assets.hostname")$$page.base$$page.properties.("material.favicon")$">
Review Comment:
The icon link of all modules is broken, but the pekko homepage is not, which also proves this. `$page.base$` is the path of a specific project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#issuecomment-1975388098
> I can take a look at this tomorrow
Ill wait till tomorrow to see if there is an update on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#issuecomment-1975376571
> @samueleresca @mdedetrich I built this locally and then used it in pekko-grpc paradox build (also locally) - but none of the assets.hostname dependent paths were mapped - all the links are relative. This includes the existing paths that already support assets.hostname.
>
> edit - I tested with pekko-site repo and these changes seem to work there
Have you tried to also specify the `assets.hostname` property into the downstream module (e.g.: [paradoxProperties in incubator-pekko-(http|grpc)](https://github.com/apache/incubator-pekko-http/blob/0dfd4ff9cee64d3dcf4b26164a69fa6363772e50/build.sbt#L434))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#issuecomment-1975331229
@samueleresca @mdedetrich I built this locally and then used it in pekko-grpc paradox build (also locally) - but none of the assets.hostname dependent paths were mapped - all the links are relative. This includes the existing paths that already support assets.hostname.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#issuecomment-1976301663
seems to be included in #127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#issuecomment-1976340534
Added an issue tracking the `page.base` paths in the static assets: https://github.com/apache/incubator-pekko-sbt-paradox/issues/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#issuecomment-1975383348
The `$page.properties.("assets.hostname")$$page.base$` pattern is already used in https://github.com/apache/incubator-pekko-sbt-paradox/blob/d47e88d12a922d678048306d9b069106162cb00f/theme/src/main/assets/page.st#L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#discussion_r1510544311
##########
theme/src/main/assets/page.st:
##########
@@ -46,7 +46,7 @@ $!
$ elseif (page.properties.("material.author")) $
<meta name="author" content="$page.properties.("site.author")$">
$ endif $
- <link rel="shortcut icon" href="$page.base$$page.properties.("material.favicon")$">
+ <link rel="shortcut icon" href="$page.properties.("assets.hostname")$$page.base$$page.properties.("material.favicon")$">
Review Comment:
> The link is to https://pekko.apache.org/docs/pekko-http/current/assets/images/pekko_logo.png
>
> Should be https://pekko.apache.org/assets/images/pekko_logo.png
The previous comments should be no problem. `$page.base$` is not a problem. At present, it is always the root directory of the project, that is.
The documents generated by all these modules (http, connector, pekko) are "assets/xxxx", even if the string template adds `assets.home`, but due to pekko, conn Ector These modules do not have the default value of `assets.home`, so they still do not point the path to CDN.
So I think the PR needs to set a default value for assets.home, or explicitly add the assets.home configuration value for each project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #126: try to fix broken logo and favicon
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try to fix broken logo and favicon [incubator-pekko-sbt-paradox]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #126:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#discussion_r1510510536
##########
theme/src/main/assets/page.st:
##########
@@ -46,7 +46,7 @@ $!
$ elseif (page.properties.("material.author")) $
<meta name="author" content="$page.properties.("site.author")$">
$ endif $
- <link rel="shortcut icon" href="$page.base$$page.properties.("material.favicon")$">
+ <link rel="shortcut icon" href="$page.properties.("assets.hostname")$$page.base$$page.properties.("material.favicon")$">
Review Comment:
I doubt that this is related to https://github.com/apache/incubator-pekko-sbt-paradox/pull/86. I'm not sure if page.properties ("assets.hostname") exists, but using it with $page.base$ may be a bad idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org