You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Simon Pepping (JIRA)" <ji...@apache.org> on 2010/10/25 13:45:24 UTC
[jira] Created: (FOR-1205) In the tigris skin the @import
statements have syntactic errors
In the tigris skin the @import statements have syntactic errors
---------------------------------------------------------------
Key: FOR-1205
URL: https://issues.apache.org/jira/browse/FOR-1205
Project: Forrest
Issue Type: Bug
Components: Core operations
Affects Versions: 0.8
Reporter: Simon Pepping
With the tigris skin the following statements appear in the HTML files:
<style type="text/css">
/* */
@import "
../
skin/tigris.css";
@import "
../
skin/quirks.css";
@import "
../
skin/inst.css";
/* */
</style>
This does not work since each URL should be on a single line:
<style type="text/css">
/* */
@import "skin/tigris.css";
@import "skin/quirks.css";
@import "skin/inst.css";
/* */
</style>
The error is in main/webapp/skins/tigris/xslt/html/site-to-xhtml.xsl:
<style type="text/css">
/* <![CDATA[ */
@import "]]>
<xsl:value-of select="$root"/>
<![CDATA[skin/tigris.css";
@import "]]>
<xsl:value-of select="$root"/>
<![CDATA[skin/quirks.css";
@import "]]>
<xsl:value-of select="$root"/>
<![CDATA[skin/inst.css";
/* ]]> */
</style>
which should be changed to:
<style type="text/css">
<xsl:text>
/* <![CDATA[ */
@import "]]></xsl:text>
<xsl:value-of select="$root"/>
<xsl:text><![CDATA[skin/tigris.css";
import "]]></xsl:text>
<xsl:value-of select="$root"/>
<xsl:text><![CDATA[skin/quirks.css";
@import "]]></xsl:text>
<xsl:value-of select="$root"/>
<xsl:text><![CDATA[skin/inst.css";
/* ]]> */
</xsl:text>
</style>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-1205) In the tigris skin the @import
statements have syntactic errors
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley updated FOR-1205:
--------------------------------
Other Info: [Patch available]
> In the tigris skin the @import statements have syntactic errors
> ---------------------------------------------------------------
>
> Key: FOR-1205
> URL: https://issues.apache.org/jira/browse/FOR-1205
> Project: Forrest
> Issue Type: Bug
> Components: Core operations
> Affects Versions: 0.8
> Reporter: Simon Pepping
>
> With the tigris skin the following statements appear in the HTML files:
> <style type="text/css">
> /* */
> @import "
> ../
> skin/tigris.css";
> @import "
> ../
> skin/quirks.css";
> @import "
> ../
> skin/inst.css";
> /* */
> </style>
> This does not work since each URL should be on a single line:
> <style type="text/css">
> /* */
> @import "skin/tigris.css";
> @import "skin/quirks.css";
> @import "skin/inst.css";
> /* */
> </style>
> The error is in main/webapp/skins/tigris/xslt/html/site-to-xhtml.xsl:
> <style type="text/css">
> /* <![CDATA[ */
> @import "]]>
> <xsl:value-of select="$root"/>
> <![CDATA[skin/tigris.css";
> @import "]]>
> <xsl:value-of select="$root"/>
> <![CDATA[skin/quirks.css";
> @import "]]>
> <xsl:value-of select="$root"/>
> <![CDATA[skin/inst.css";
> /* ]]> */
> </style>
> which should be changed to:
> <style type="text/css">
> <xsl:text>
> /* <![CDATA[ */
> @import "]]></xsl:text>
> <xsl:value-of select="$root"/>
> <xsl:text><![CDATA[skin/tigris.css";
> import "]]></xsl:text>
> <xsl:value-of select="$root"/>
> <xsl:text><![CDATA[skin/quirks.css";
> @import "]]></xsl:text>
> <xsl:value-of select="$root"/>
> <xsl:text><![CDATA[skin/inst.css";
> /* ]]> */
> </xsl:text>
> </style>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FOR-1205) In the tigris skin the @import statements
have syntactic errors
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley closed FOR-1205.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.9-dev
Thanks. Patch applied. I used "xsl:text" as suggested, but did it slightly differently.
> In the tigris skin the @import statements have syntactic errors
> ---------------------------------------------------------------
>
> Key: FOR-1205
> URL: https://issues.apache.org/jira/browse/FOR-1205
> Project: Forrest
> Issue Type: Bug
> Components: Core operations
> Affects Versions: 0.8
> Reporter: Simon Pepping
> Fix For: 0.9-dev
>
>
> With the tigris skin the following statements appear in the HTML files:
> <style type="text/css">
> /* */
> @import "
> ../
> skin/tigris.css";
> @import "
> ../
> skin/quirks.css";
> @import "
> ../
> skin/inst.css";
> /* */
> </style>
> This does not work since each URL should be on a single line:
> <style type="text/css">
> /* */
> @import "skin/tigris.css";
> @import "skin/quirks.css";
> @import "skin/inst.css";
> /* */
> </style>
> The error is in main/webapp/skins/tigris/xslt/html/site-to-xhtml.xsl:
> <style type="text/css">
> /* <![CDATA[ */
> @import "]]>
> <xsl:value-of select="$root"/>
> <![CDATA[skin/tigris.css";
> @import "]]>
> <xsl:value-of select="$root"/>
> <![CDATA[skin/quirks.css";
> @import "]]>
> <xsl:value-of select="$root"/>
> <![CDATA[skin/inst.css";
> /* ]]> */
> </style>
> which should be changed to:
> <style type="text/css">
> <xsl:text>
> /* <![CDATA[ */
> @import "]]></xsl:text>
> <xsl:value-of select="$root"/>
> <xsl:text><![CDATA[skin/tigris.css";
> import "]]></xsl:text>
> <xsl:value-of select="$root"/>
> <xsl:text><![CDATA[skin/quirks.css";
> @import "]]></xsl:text>
> <xsl:value-of select="$root"/>
> <xsl:text><![CDATA[skin/inst.css";
> /* ]]> */
> </xsl:text>
> </style>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.