You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2022/10/11 05:10:47 UTC
[shardingsphere] branch master updated: Remove useless @ToString and @Data (#21479)
This is an automated email from the ASF dual-hosted git repository.
zhonghongsheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 575dd651e2c Remove useless @ToString and @Data (#21479)
575dd651e2c is described below
commit 575dd651e2cf8a71e29dcdbad3f0beef4e19ae44
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Tue Oct 11 13:10:38 2022 +0800
Remove useless @ToString and @Data (#21479)
* Remove useless @ToString and @Data
* Remove useless @ToString and @Data
---
.../data/pipeline/api/pojo/CreateConsistencyCheckJobParameter.java | 4 ++--
.../data/pipeline/api/pojo/CreateMigrationJobParameter.java | 4 ++--
.../data/pipeline/api/pojo/TableBasedPipelineJobInfo.java | 2 --
.../data/pipeline/scenario/migration/MigrationJobAPIImpl.java | 6 +++---
4 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateConsistencyCheckJobParameter.java b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateConsistencyCheckJobParameter.java
index ab9d1923e5d..66b0ae9924b 100644
--- a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateConsistencyCheckJobParameter.java
+++ b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateConsistencyCheckJobParameter.java
@@ -17,7 +17,7 @@
package org.apache.shardingsphere.data.pipeline.api.pojo;
-import lombok.Data;
+import lombok.Getter;
import lombok.RequiredArgsConstructor;
import java.util.Properties;
@@ -26,7 +26,7 @@ import java.util.Properties;
* Create consistency check job parameter.
*/
@RequiredArgsConstructor
-@Data
+@Getter
public final class CreateConsistencyCheckJobParameter {
private final String jobId;
diff --git a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateMigrationJobParameter.java b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateMigrationJobParameter.java
index 20967194e0e..9629da29985 100644
--- a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateMigrationJobParameter.java
+++ b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/CreateMigrationJobParameter.java
@@ -17,11 +17,11 @@
package org.apache.shardingsphere.data.pipeline.api.pojo;
-import lombok.Data;
+import lombok.Getter;
import lombok.RequiredArgsConstructor;
@RequiredArgsConstructor
-@Data
+@Getter
public final class CreateMigrationJobParameter {
private final String sourceResourceName;
diff --git a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/TableBasedPipelineJobInfo.java b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/TableBasedPipelineJobInfo.java
index e7102b9e74a..05ab6eb54c8 100644
--- a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/TableBasedPipelineJobInfo.java
+++ b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/pojo/TableBasedPipelineJobInfo.java
@@ -19,14 +19,12 @@ package org.apache.shardingsphere.data.pipeline.api.pojo;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
-import lombok.ToString;
/**
* Table based pipeline job info.
*/
@RequiredArgsConstructor
@Getter
-@ToString(callSuper = true)
public final class TableBasedPipelineJobInfo implements PipelineJobInfo {
private final PipelineJobMetaData jobMetaData;
diff --git a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobAPIImpl.java b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobAPIImpl.java
index 72fe7f49559..6302b2673f4 100644
--- a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobAPIImpl.java
+++ b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobAPIImpl.java
@@ -402,9 +402,9 @@ public final class MigrationJobAPIImpl extends AbstractInventoryIncrementalJobAP
throw new RuntimeException(ex);
}
extendYamlJobConfiguration(result);
- MigrationJobConfiguration jobConfiguration = new YamlMigrationJobConfigurationSwapper().swapToObject(result);
- start(jobConfiguration);
- return jobConfiguration.getJobId();
+ MigrationJobConfiguration jobConfig = new YamlMigrationJobConfigurationSwapper().swapToObject(result);
+ start(jobConfig);
+ return jobConfig.getJobId();
}
private YamlRootConfiguration getYamlRootConfiguration(final String databaseName, final Map<String, Map<String, Object>> yamlDataSources, final Collection<RuleConfiguration> rules) {