You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 00:03:42 UTC
[GitHub] [superset] jsoref opened a new pull request, #19676: chore(frontend): Spelling
jsoref opened a new pull request, #19676:
URL: https://github.com/apache/superset/pull/19676
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Subset of #19648 per https://github.com/apache/superset/pull/19648#pullrequestreview-939431828
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19676: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19676:
URL: https://github.com/apache/superset/pull/19676#discussion_r1087262326
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -228,7 +228,7 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
}
const activeTab = getItem(LocalStorageKeys.homepage_activity_filter, null);
setActiveState(collapseState.length > 0 ? collapseState : DEFAULT_TAB_ARR);
- getRecentAcitivtyObjs(user.userId!, recent, addDangerToast, otherTabFilters)
+getRecentActivityObjs(user.userId!, recent, addDangerToast, otherTabFilters)
Review Comment:
```suggestion
getRecentActivityObjs(user.userId!, recent, addDangerToast, otherTabFilters)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19676: chore(frontend): Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on code in PR #19676:
URL: https://github.com/apache/superset/pull/19676#discussion_r848973735
##########
docs/static/resources/openapi.json:
##########
@@ -15618,7 +15618,7 @@
"description": "Menu items in a forest like data structure",
"items": {
"properties": {
- "childs": {
+ "children": {
Review Comment:
It appears to be updated by commits that change things: https://github.com/apache/superset/commit/02ef9ca4cd60d0d05f0afd2cebc1cabb83dfd4df
The relevant items should be changed below...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a diff in pull request #19676: chore(frontend): Spelling
Posted by GitBox <gi...@apache.org>.
nytai commented on code in PR #19676:
URL: https://github.com/apache/superset/pull/19676#discussion_r848975184
##########
docs/static/resources/openapi.json:
##########
@@ -15618,7 +15618,7 @@
"description": "Menu items in a forest like data structure",
"items": {
"properties": {
- "childs": {
+ "children": {
Review Comment:
unfortunately I think this is part of the api, you would have to update flask appbuilder to fix it and it would be a breaking change. @dpgaspar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a diff in pull request #19676: chore(frontend): Spelling
Posted by GitBox <gi...@apache.org>.
ktmud commented on code in PR #19676:
URL: https://github.com/apache/superset/pull/19676#discussion_r848972722
##########
docs/static/resources/openapi.json:
##########
@@ -15618,7 +15618,7 @@
"description": "Menu items in a forest like data structure",
"items": {
"properties": {
- "childs": {
+ "children": {
Review Comment:
Isn't this file programmatically generated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on pull request #19676: chore(frontend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on PR #19676:
URL: https://github.com/apache/superset/pull/19676#issuecomment-1404270499
The item that was listed was already dropped. I think I left the item unresolved because in theory someone should eventually address it somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19676: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19676:
URL: https://github.com/apache/superset/pull/19676#issuecomment-1404243501
@jsoref much like your other PR, we really appreciate cleaning up all these typos! Would you be able to remove the auto-generated files and rebase to mitigate the conflicts? Hopefully we can usher this through (CC @amitmiran137 for possible assistance here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19676: chore(frontend): Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on code in PR #19676:
URL: https://github.com/apache/superset/pull/19676#discussion_r848984567
##########
docs/static/resources/openapi.json:
##########
@@ -15618,7 +15618,7 @@
"description": "Menu items in a forest like data structure",
"items": {
"properties": {
- "childs": {
+ "children": {
Review Comment:
I'm quite happy to drop anything that proves to be problematic. It's not a big deal.
And in the interest of moving things forward while I'm away, I'll drop this now.
You're welcome to fix it w/o me, or I can look at it once the rest merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19676: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #19676:
URL: https://github.com/apache/superset/pull/19676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on pull request #19676: chore(frontend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on PR #19676:
URL: https://github.com/apache/superset/pull/19676#issuecomment-1404269087
This is a strict rebase. Lemme see about finding the autogenerated files and dropping them (notably, i think that some linters are complaining -- I suspect that I'd rather someone else make the linters happy, I don't have infinite time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a diff in pull request #19676: chore(frontend): Spelling
Posted by GitBox <gi...@apache.org>.
ktmud commented on code in PR #19676:
URL: https://github.com/apache/superset/pull/19676#discussion_r849015628
##########
docs/static/resources/openapi.json:
##########
@@ -15618,7 +15618,7 @@
"description": "Menu items in a forest like data structure",
"items": {
"properties": {
- "childs": {
+ "children": {
Review Comment:
https://github.com/apache/superset/blob/3313530f4de2d1cf1719d6b2beda89a5bfbba2cd/superset/cli/update.py#L148-L152
This file is generated by a script. There is a superset command: `superset update-api-docs` but unfortunately it is not documented anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19676: chore(frontend): Spelling
Posted by codecov.
codecov[bot] commented on PR #19676:
URL: https://github.com/apache/superset/pull/19676#issuecomment-1404278289
# [Codecov](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19676](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec71d44) into [master](https://codecov.io/gh/apache/superset/commit/8c388780489357838f81af378688aadf2c7388ca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c38878) will **decrease** coverage by `8.98%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #19676 +/- ##
==========================================
- Coverage 67.31% 58.34% -8.98%
==========================================
Files 1879 499 -1380
Lines 72093 34560 -37533
Branches 7897 0 -7897
==========================================
- Hits 48530 20163 -28367
+ Misses 21535 14397 -7138
+ Partials 2028 0 -2028
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.64% <100.00%> (ø)` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.53% <100.00%> (ø)` | |
| python | `58.34% <100.00%> (-23.60%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `51.64% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `99.35% <ø> (ø)` | |
| [superset/cli/importexport.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2ltcG9ydGV4cG9ydC5weQ==) | `20.00% <ø> (-60.00%)` | :arrow_down: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `24.03% <ø> (-69.00%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `62.32% <ø> (-14.73%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `37.59% <ø> (-37.52%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `64.20% <100.00%> (-26.69%)` | :arrow_down: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/tags/core.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFncy9jb3JlLnB5) | `4.54% <0.00%> (-95.46%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-87.88%)` | :arrow_down: |
| ... and [1679 more](https://codecov.io/gh/apache/superset/pull/19676?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19676: chore(frontend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19676:
URL: https://github.com/apache/superset/pull/19676#issuecomment-1404355507
Looks like this'll need a codeowner approval from @michael-s-molina @geido @ktmud as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org