You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/06/26 06:48:00 UTC
[GitHub] zeppelin pull request #2437: [ZEPPELIN-2582][DOCS] docs for interpreter bind...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2437
[ZEPPELIN-2582][DOCS] docs for interpreter binding modes
### What is this PR for?
Updated `interpreter_binding_mode.md` since users are sometimes confused what this mode means and there is already opened JIRA issue. This documentation will be helpful to Zeppelin users.
**disclaimer: content was copied from [here](https://medium.com/@leemoonsoo/apache-zeppelin-interpreter-mode-explained-bae0525d0555) with author's consent.**
### What type of PR is it?
[Documentation]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2582](https://issues.apache.org/jira/browse/ZEPPELIN-2582)
### How should this be tested?
1. setup rvm 2.1.0+ and install required bundles for `docs/`
2. bundle exec jekyll serve --watch
3. http://localhost:4000/usage/interpreter/interpreter_binding_mode.html
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - This PR is about docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2582/docs-for-interpreter-modes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2437
----
commit 56836205d8b4555746e66306b32714183866ed15
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-26T06:42:01Z
feat: Add images
commit b43a4daf6165465885b8ec629cf49b7b7c5d10ef
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-26T06:42:19Z
docs: Update interpreter binding mode page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Yes, correct. Except `Shared`, user cannot share anything directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2437: [ZEPPELIN-2582][DOCS] docs for interpreter bind...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@1ambda Thanks for finishing the diagrams. I would probably put the SparkContext inside the interpreter process but outside the InterpreterGroup; but if @zjffdu is happy with the diagrams I guess it doesn't matter. I've gone through interpreter_binding_mode.md, tidying up the English some more. I'm done with my edits now, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@cacti77 it's provided as of 0.8.0-SNAPSHOT.
- http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/interpreter/interpreter_binding_mode.html
here are the background
- we re-organized contents structure of docs in 0.8.0-SNAPSHOT
- the interpreter binding page was created at that time (so it's currently empty)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
resolved @zjffdu's comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@zjffdu I like that diagram, it's more precise and accurate. But would be nice to
- colorize
- and attach note UI so that users easily understand
like
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Thanks for the review.
@felixcheung Resolved all comments.
@zjffdu @cacti77 Update imgs and description. See the last 2 commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@cacti77 So, you want to add some description for **per user** as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Thanks @1ambda for the help on the updated diagram, it looks create. Just leave a minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@1ambda Thanks for the tip. I was hoping there'd be an easier way to see the web page; oh well:).
> 1 InterpreterGroup matchs 1 Interpreter Process
Are you sure about this?@felixcheung above said:
> Each Interpreter process can have multiple Interpreter Groups
I still think it would be good to distinguish Interpreter Groups from the Interpreter Process in the diagrams. After looking at the code for [InterpreterGroup ](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java) it makes a bit more sense to me now. One InterpreterGroup can be associated with multiple sessions, and each session id is associated with a list of interpreters. I'm just not sure yet [how the sessions are generated with respect to notes, users, or their combination](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java#L41-L44)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
I added your summary table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
it was an honor to make more correct, concise documentation with your help.
Merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@1ambda Look [here ](https://docs.google.com/presentation/d/1eIdnReyFxTAAOKTwc_a_mynhlt9mNq6GQAAewFP00PI/edit?usp=sharing) please. I've added 1, 2 or 3 to the Interpreters in the first 3 diagrams. I've only got the patience to add the InterpreterGroup to the very first diagram, but it should be added to all 6 diagrams. In the two scoped-mode diagrams (diagrams 2 and 5) the InterpreterGroup should contain all 3 sessions. In the last 3 diagrams I presume the red SparkContext box should be _outside_ the InterpreterGroup boxes since the code for the latter doesn't appear to directly reference the SparkContext. But @zjffdu should be able to confirm this is true.
Hope this helps you a bit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@cacti77 Yes, it would be a good summary. Let me add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Please let me know if we need to add / improve / modify something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
> from the code perspective, there's only one InterpreterGroup for scoped mode, but multiple sessions in one InterpreterGroup.
If this is true then surely the diagram for scoped mode should only have one InterpreterGroup in it, but with multiple (Spark?) sessions inside that, with several interpreters inside each session?
Also, this 'per note' and 'per user' does appear to add another dimension. So, to explain what's happening you'd need one table for shared/scoped/isolated for the 'per user' mode and another table again for shared/scoped/isolated for the 'per note' mode.
It would also be good to have a column or table explaining how data can be shared, or not, between notebooks in the 3 different modes. As a Zeppelin user I find all these different combinations really confusing. Maybe an architectural diagram of how the different parts of Zeppelin talk to each other would help here. Or maybe the product itself should be simplified to remove a lot of these combinations, especially if they're not used much?!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@cacti77
Your comment is helpful. You can preview the page like
- [setup rvm 2.1.0+ and install required bundles for docs/](https://github.com/apache/zeppelin/tree/master/docs#build-documentation)
- bundle exec jekyll serve --watch
- open `http://localhost:4000/usage/interpreter/interpreter_binding_mode.html`
1. `1 InterpreterGroup` matchs `1 Interpreter Process`, it might contains multiple sessions (e.g **scope mode**
2. I will update it.
3. I will udpate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@zjffdu regarding that, I have question as well.
- In isolated mode / shared mode, can't we share variables via `z.put?` and `z.get`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Deployed
- http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/interpreter/interpreter_binding_mode.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@zjffdu Thanks for the review.
Now it looks like
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@cacti77 @1ambda How about diagram like this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@cacti77 @zjffdu Please tell me if this is incorrect
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@zjffdu enhanced description according to your suggestion. could you check that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2437: [ZEPPELIN-2582][DOCS] docs for interpreter bind...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2437
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
CI failed but irrelevant.
- https://travis-ci.org/1ambda/zeppelin/jobs/246983015
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@1ambda Thanks; I can try - I've requested edit permission on that doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Sorry, I've never done a PR before so I'm not familiar with how best to contribute my suggestions. I'm also finding it difficult to see what the final docs page would look like as a whole.
1. The diagrams are looking great but shouldn't we also show the InterpreterGroup since it is mentioned in the UI itself and in the text of this help page? Does the InterpreterGroup contain the session, or is it vice versa?
1. In the first set of 3 diagrams maybe distinguish the Interpreters in each session (e.g., Interpreter 1, Interpreter 2, Interpreter 3; don't use A, B, C because you've already used that to distinguish the notes!).
1. Thanks for adding the extra table column: typo (occurs twice): share objets --> share obje**c**ts (and remove ')' after "via ResourcePool")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Thanks for doing this. I looked at the screenshots above. The diagrams are very helpful! Are you also going to add the table I created at https://issues.apache.org/jira/browse/ZEPPELIN-2582?focusedCommentId=16024796&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16024796 or do you think it doesn't add anything useful?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2437
It is better to mention in what dimension of these modes. (per user or per note).
And from the code perspective, there's only one `InterpreterGroup` for scoped mode, but multiple sessions in one InterpreterGroup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
CI failed but irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Thanks @1ambda . So, looking at #2371, it looks like a user would simply click on the dropdown and then Interpreter > Interpreter Binding Mode to access the new web page. Is that correct? Basically, as long as all the info about interpreter binding modes is in one place and easy to find, that's all I care about:).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
resolved @cacti77's all comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2437: [ZEPPELIN-2582][DOCS] docs for interpreter bind...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2437
[ZEPPELIN-2582][DOCS] docs for interpreter binding modes
### What is this PR for?
Updated `interpreter_binding_mode.md` since users are sometimes confused what this mode means and there is already opened JIRA issue. This documentation will be helpful to Zeppelin users.
**disclaimer: content was copied from [here](https://medium.com/@leemoonsoo/apache-zeppelin-interpreter-mode-explained-bae0525d0555) with author's consent.**
### What type of PR is it?
[Documentation]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2582](https://issues.apache.org/jira/browse/ZEPPELIN-2582)
### How should this be tested?
1. setup rvm 2.1.0+ and install required bundles for `docs/`
2. bundle exec jekyll serve --watch
3. http://localhost:4000/usage/interpreter/interpreter_binding_mode.html
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - This PR is about docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2582/docs-for-interpreter-modes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2437
----
commit 56836205d8b4555746e66306b32714183866ed15
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-26T06:42:01Z
feat: Add images
commit b43a4daf6165465885b8ec629cf49b7b7c5d10ef
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-26T06:42:19Z
docs: Update interpreter binding mode page
commit 43e8b02396a25f5a3fdad50ee3486f690bd51ccb
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-27T01:16:18Z
docs: Add summary table of @cacti77
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@1ambda Never mind; I'll edit my own copy as you suggested previously.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
1. Added the **sharing objects** column.
2. Enhanced the description for **per user**
3. Added images for UI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@1ambda And it looks good to me too; thanks for being patient and making all those changes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Sure, users can easily access the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Apologies @1ambda for not interacting with this PR properly; I may have overlooked some of your recent edits in the version of interpreter_binding_mode.md I commented on yesterday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Thanks @cacti77 & @1ambda. The diagram is correct. One interpreter process would have only one InterperterGroup, and InterpreterGroup could have one session for shared/isolated mode, and multiple sessions for scoped mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2437
>> So, each Note have their own dedicated session but still it’s possible to share objects between different Interpreter Groups while they’re in the same JVM process.
Is this correct ? AFAIK, only sparkcontext is shared in scoped mode. Variable defined in session 1 can not be used in session 2
>> From the code perspective, there is only one `InterpreterGroup` for the scoped mode, but multiple sessions in one `InterpreterGroup`.
Sorry, I think we can remove this before we find a more proper way to explain. This might confuse users too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@zjffdu Thanks. Let me add the description into the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by cacti77 <gi...@git.apache.org>.
Github user cacti77 commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@1ambda One question please: Do these docs constitute a new web page in Zeppelin's docs? I'm just wondering how a user would navigate to this new information on binding modes from the Docs home page. Will the new page be linked to from under http://zeppelin.apache.org/docs/0.7.2/manual/interpreters.html#interpreter-binding-mode for example? Or will it become part of the interpreters.html page itself?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@zjffdu yes, it would be more clear.
@jongyoul. As zjffdu said, variables (e.g scala variables, ...) in the scope mode can't be shared directly. is it correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@jongyoul Thanks!
I fixed the incorrect description. Now it looks like
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@cacti77
1. 
2. Could you provide an example diagram? you can duplicate and edit [this](https://docs.google.com/presentation/d/1Y8lAJFlMO-Jm6ObqcTPmZa9_S9NfyFDsv93xSXvO7l0/edit?usp=sharing) with the description to be included?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
@zjffdu Let me work on the new diagram based on yours, and will share it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
CI failed but irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2437
awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Many sentences should be updated since our major unit is the session, not interpreter group in the screenshots. Let me updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2437
We can, but this is via `ResourcePool`. We might need to say that we could share object via resource pool. Otherwise users might be confused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2437
Now it looks like
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---