You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Aaron T. Myers (JIRA)" <ji...@apache.org> on 2011/06/22 09:21:47 UTC

[jira] [Commented] (HDFS-351) Could FSEditLog report problems more elegantly than with System.exit(-1)

    [ https://issues.apache.org/jira/browse/HDFS-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053094#comment-13053094 ] 

Aaron T. Myers commented on HDFS-351:
-------------------------------------

Steve, I believe this was fixed long ago. Can you confirm that the current handling meets your requirements?

> Could FSEditLog report problems more elegantly than with System.exit(-1)
> ------------------------------------------------------------------------
>
>                 Key: HDFS-351
>                 URL: https://issues.apache.org/jira/browse/HDFS-351
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Steve Loughran
>            Priority: Minor
>
> When FSEdit encounters problems, it prints something and then exits.
> It would be better for any in-JVM deployments of FSEdit for these to be raised in some other way (such as throwing an exception), rather than taking down the whole JVM. That could be in JUnit tests, or it could be inside other applications. Test runners and the like can intercept those System.exit() calls with their own Security Manager -often turning the System.exit() operation into an exception there and then. If FSEdit did that itself, it may be easier to stay in control. 
> The current approach has some benefits -it can exit regardless of which thread has encountered problems, but it is tricky to test.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira