You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (Created) (JIRA)" <ji...@apache.org> on 2012/01/26 03:37:40 UTC

[jira] [Created] (CASSANDRA-3786) [patch] fix bad comparison of IColumn to ByteBuffer

[patch] fix bad comparison of IColumn to ByteBuffer
---------------------------------------------------

                 Key: CASSANDRA-3786
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3786
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.0.7
            Reporter: Dave Brosius
            Priority: Trivial
         Attachments: bad_compare.diff

Code does

firstColumn.equals(startKey)

changed to 

firstColumn.name().equals(startKey)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CASSANDRA-3786) [patch] fix bad comparison of IColumn to ByteBuffer

Posted by "Jonathan Ellis (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-3786.
---------------------------------------

    Resolution: Fixed
      Reviewer: jbellis
    
> [patch] fix bad comparison of IColumn to ByteBuffer
> ---------------------------------------------------
>
>                 Key: CASSANDRA-3786
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3786
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.1
>
>         Attachments: bad_compare.diff
>
>
> Code does
> firstColumn.equals(startKey)
> changed to 
> firstColumn.name().equals(startKey)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3786) [patch] fix bad comparison of IColumn to ByteBuffer

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193603#comment-13193603 ] 

Jonathan Ellis commented on CASSANDRA-3786:
-------------------------------------------

This is tagged affects 1.0.7 but patch only applies to trunk for me.  Do we need a different patch for 1.0 branch, or should this be affects-1.1?
                
> [patch] fix bad comparison of IColumn to ByteBuffer
> ---------------------------------------------------
>
>                 Key: CASSANDRA-3786
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3786
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.7
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: bad_compare.diff
>
>
> Code does
> firstColumn.equals(startKey)
> changed to 
> firstColumn.name().equals(startKey)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3786) [patch] fix bad comparison of IColumn to ByteBuffer

Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3786:
--------------------------------------

    Affects Version/s:     (was: 1.0.7)
                       1.1
        Fix Version/s: 1.1
             Assignee: Dave Brosius

looks to me like the latter -- will commit on that basis, please reopen if I'm wrong
                
> [patch] fix bad comparison of IColumn to ByteBuffer
> ---------------------------------------------------
>
>                 Key: CASSANDRA-3786
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3786
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.1
>
>         Attachments: bad_compare.diff
>
>
> Code does
> firstColumn.equals(startKey)
> changed to 
> firstColumn.name().equals(startKey)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3786) [patch] fix bad comparison of IColumn to ByteBuffer

Posted by "Dave Brosius (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated CASSANDRA-3786:
------------------------------------

    Attachment: bad_compare.diff
    
> [patch] fix bad comparison of IColumn to ByteBuffer
> ---------------------------------------------------
>
>                 Key: CASSANDRA-3786
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3786
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.7
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: bad_compare.diff
>
>
> Code does
> firstColumn.equals(startKey)
> changed to 
> firstColumn.name().equals(startKey)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira