[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1398: MINIFICPP-1915 Fix clang-tidy for newly created branch

[GitBox <gi...@apache.org>]

adam-markovics commented on code in PR #1398:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1398#discussion_r951171486


##########
.github/workflows/ci.yml:
##########
@@ -151,13 +151,20 @@ jobs:
         run: cd build && make flake8
       - id: files
         uses: Ana06/get-changed-files@v2.1.0
+        continue-on-error: true
       - name: clang-tidy
         run: |
+          if [[ -n "${{ steps.files.outputs.all }}" ]]; then
+            FILES="${{ steps.files.outputs.all }}"
+          else
+            git fetch origin main && git checkout -b main origin/main || true

Review Comment:
   I think that checkout is unnecessary, we could run `git diff` right against `origin/main` after `git fetch` has run.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org