[GitHub] [spark] srowen commented on a change in pull request #31953: [SPARK-34855][CORE]spark context - avoid using local lazy val for callSite

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #31953:
URL: https://github.com/apache/spark/pull/31953#discussion_r600499113



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2186,13 +2186,22 @@ class SparkContext(config: SparkConf) extends Logging {
    * has overridden the call site using `setCallSite()`, this will return the user's version.
    */
   private[spark] def getCallSite(): CallSite = {
-    lazy val callSite = Utils.getCallSite()
-    CallSite(
-      Option(getLocalProperty(CallSite.SHORT_FORM)).getOrElse(callSite.shortForm),
-      Option(getLocalProperty(CallSite.LONG_FORM)).getOrElse(callSite.longForm)
-    )
+    if (getLocalProperty(CallSite.SHORT_FORM) == null

Review comment:
       You can probably simplify by creating two Options for the two properties as vals first




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org