[jira] [Commented] (COUCHDB-3067) Improve couch_log implementation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385279#comment-15385279 ] 

ASF GitHub Bot commented on COUCHDB-3067:
-----------------------------------------

GitHub user davisp opened a pull request:

    https://github.com/apache/couchdb-couch-log/pull/13

    Make couch_log smarter

    This drops the lager and goldrush dependencies and instead moves all
    logic to couch_log so that we can make our logging work more closely
    with the existing configuration system.
    
    COUCHDB-3067
    
    ---
    
    Don't be overly alarmed at the size of this diff. A large portion of it is pulled in from lager for trunc_io support along with an io_lib:format implementation that uses said trunc_io. Other than that  its mostly just a clean up of the current couch_log app with some added features like logging to files.
    
    I've only done minimal testing on this so far. It passes `make javascript` with the stderr logger and I can change log levels during a test run. There are a few log lines that need cleaned up that we can do with other PRs. Mostly its just log lines that include a trailing new line when the shouldn't. There's also a log from the emulator that does the same that I want to track down to remove the trailing newline.
    
    This has stderr and file backends. Tomorrow I'm gonna add a syslog backend. After that it'll be all about adding whatever tests people think are necessary. There really isn't a shit load of testing around logging (given, if it were broke I think we'd know quickly). However with the current implementation we should be able get fairly deep testing coverage quickly if people actually want to push on it.
    
    For the moment this is just for review, I want to get the stderr implementation working before we actually merge and also obviously address any feedback to this PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch-log 3067-improve-couch-log

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-log/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit fa16ed428adeee4b3c5fbb714ffee7f8f4b8a83d
Author: Paul J. Davis <pa...@gmail.com>
Date:   2016-07-20T00:14:33Z

    Make couch_log smarter
    
    This drops the lager and goldrush dependencies and instead moves all
    logic to couch_log so that we can make our logging work more closely
    with the existing configuration system.
    
    COUCHDB-3067

----


> Improve couch_log implementation
> --------------------------------
>
>                 Key: COUCHDB-3067
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3067
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Logging
>            Reporter: Paul Joseph Davis
>
> The current couch_log implementation splits its configuration between CouchDB's config app and lager's use of the standard sys.config system. Generally speaking we don't use the fancy features of lager so there's not much reason to keep it around. This ticket is to remove lager and its dependencies and fix up the short comings of the existing couch_log app.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)