You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/18 16:38:12 UTC

Review Request: Fix for CLOUDSTACK-2181: Scale down is allowed, which is not expected

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11936/
-----------------------------------------------------------

Review request for cloudstack and Nitin Mehta.


Description
-------

CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
 being scale down ;but not allowed when both resources are being scaledown


This addresses bug CLOUDSTACK-2181.


Diffs
-----

  server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 

Diff: https://reviews.apache.org/r/11936/diff/


Testing
-------

Tested locally


Thanks,

Harikrishna Patnala


Re: Review Request: Fix for CLOUDSTACK-2181: Scale down is allowed, which is not expected

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11936/#review22324
-----------------------------------------------------------


Commit ad33e6d475adf1abf45e3d983aaaba71460f1c3b in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ad33e6d ]

CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
 being scale down ;but not allowed when both resources are being scaledown
Signed off by : Nitin Mehta<ni...@citrix.com>


- ASF Subversion and Git Services


On June 18, 2013, 2:38 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11936/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 2:38 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
>  being scale down ;but not allowed when both resources are being scaledown
> 
> 
> This addresses bug CLOUDSTACK-2181.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 
> 
> Diff: https://reviews.apache.org/r/11936/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request: Fix for CLOUDSTACK-2181: Scale down is allowed, which is not expected

Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11936/#review22158
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On June 18, 2013, 2:38 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11936/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 2:38 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
>  being scale down ;but not allowed when both resources are being scaledown
> 
> 
> This addresses bug CLOUDSTACK-2181.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 
> 
> Diff: https://reviews.apache.org/r/11936/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request: Fix for CLOUDSTACK-2181: Scale down is allowed, which is not expected

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11936/#review22317
-----------------------------------------------------------


Commit 1eb744fa1600f9400e407c6e3615da40b18758c1 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1eb744f ]

CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
 being scale down ;but not allowed when both resources are being scaledown
Signed off by : Nitin Mehta<ni...@citrix.com>


- ASF Subversion and Git Services


On June 18, 2013, 2:38 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11936/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 2:38 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
>  being scale down ;but not allowed when both resources are being scaledown
> 
> 
> This addresses bug CLOUDSTACK-2181.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 
> 
> Diff: https://reviews.apache.org/r/11936/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>