[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8846: Reduce the heap memory usage for segment creation

[GitBox <gi...@apache.org>]

xiangfu0 commented on code in PR #8846:
URL: https://github.com/apache/pinot/pull/8846#discussion_r901020485


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/stats/LongColumnPreIndexStatsCollector.java:
##########
@@ -100,8 +97,11 @@ public int getCardinality() {
 
   @Override
   public void seal() {
-    _sortedValues = _values.toLongArray();
-    Arrays.sort(_sortedValues);
-    _sealed = true;
+    if (!_sealed) {

Review Comment:
   If there is no sorting after seal, we should also throw exception in collect(Object) if _sealed=true to avoid any unexpected behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org