You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/15 08:19:13 UTC
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie opened a new pull request, #16: [impv] Only create one connect for single workflow submit
zhongjiajie opened a new pull request, #16:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/16
<!--Thanks for you contribute to Apache DolphinScheduler Python API, You can see more detail about contributing in https://github.com/apache/dolphinscheduler-sdk-python/DEVELOP.md .-->
## Brief Summary of The Change
<!--Please include `fixes: #XXXX(ISSUE_NUMBER)` to automatically close any corresponding issue when the pull request is merged. Alternatively if not fully closed you can say `related: #XXXX(ISSUE_NUMBER)`.-->
we directly use class ``JavaGate`` to create py4j connection in
each place we want to connect Java gateway. It will make java gateway
to many connections, this patch try to init the java_gateway instance
only one time during the workflow submit, to save the cause during
connection create
## Pull Request checklist
I confirm that the following checklist has been completed.
- [x] Add/Change **test cases** for the changes.
- [x] Add/Change the related **documentation**, should also change `docs/source/config.rst` when you change file `default_config.yaml`.
- [x] (Optional) Add your change to `UPDATING.md` when it is an incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] codecov-commenter commented on pull request #16: [impv] Only create one connect for single workflow submit
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/16#issuecomment-1314955759
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0600be3) into [main](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/0b7c0be905aa8ce710f33887472af9231f55951f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b7c0be) will **not change** coverage.
> The diff coverage is `31.25%`.
```diff
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 90.59% 90.59%
=======================================
Files 56 56
Lines 2042 2042
=======================================
Hits 1850 1850
Misses 192 192
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `90.59% <31.25%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/pydolphinscheduler/models/project.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9tb2RlbHMvcHJvamVjdC5weQ==) | `58.33% <20.00%> (ø)` | |
| [src/pydolphinscheduler/models/tenant.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9tb2RlbHMvdGVuYW50LnB5) | `56.66% <20.00%> (ø)` | |
| [src/pydolphinscheduler/models/user.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9tb2RlbHMvdXNlci5weQ==) | `50.00% <20.00%> (ø)` | |
| [src/pydolphinscheduler/core/process\_definition.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3Byb2Nlc3NfZGVmaW5pdGlvbi5weQ==) | `81.86% <33.33%> (ø)` | |
| [src/pydolphinscheduler/core/resource.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3Jlc291cmNlLnB5) | `86.36% <33.33%> (ø)` | |
| [src/pydolphinscheduler/core/task.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3Rhc2sucHk=) | `93.67% <33.33%> (ø)` | |
| [src/pydolphinscheduler/core/database.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL2RhdGFiYXNlLnB5) | `73.07% <50.00%> (ø)` | |
| [src/pydolphinscheduler/core/engine.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL2VuZ2luZS5weQ==) | `78.78% <50.00%> (ø)` | |
| [src/pydolphinscheduler/tasks/dependent.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci90YXNrcy9kZXBlbmRlbnQucHk=) | `94.57% <50.00%> (ø)` | |
| [src/pydolphinscheduler/tasks/sub\_process.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/16/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci90YXNrcy9zdWJfcHJvY2Vzcy5weQ==) | `83.33% <50.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie merged pull request #16: [impv] Only create one connect for single workflow submit
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #16:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org