[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #11838: Refactor 'hint' in SCTL

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #11838:
URL: https://github.com/apache/shardingsphere/pull/11838#discussion_r689431978



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-parser/src/main/java/org/apache/shardingsphere/sharding/distsql/parser/core/ShardingDistSQLStatementVisitor.java
##########
@@ -128,6 +138,31 @@ public ASTNode visitDropShardingBindingTableRules(final DropShardingBindingTable
         return new DropShardingBindingTableRulesStatement();
     }
     
+    @Override
+    public ASTNode visitSetShardingHintDatabaseValue(final SetShardingHintDatabaseValueContext ctx) {

Review comment:
       SetShardingHintDatabaseValueContext , use verb as the very biginning of a class name, is that a specific naming rule in this satuation ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org