(tooling-llmao) 09/23: fix: two names the templates needed and nothing provided

[ak...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

andrewmusselman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-llmao.git

commit a759d04f029fdc5bce6cdb69d9bc7d7e9ed260d4
Author: Andrew Musselman <ak...@apache.org>
AuthorDate: Mon Oct 5 15:28:45 2026 -0700

    fix: two names the templates needed and nothing provided
    
    seam.py catches BackendUnavailableError in my_key_usage and
    my_key_approvals and never imported it, so /keys raised NameError on every
    load instead of degrading to an empty column -- the exact failure the
    try/except was there to prevent.
    
    admin.ezt reads pending_count behind [if-any]. ezt's [if-any] tests
    truthiness but still requires the name to exist, so an unset optional field
    raises UnknownReference rather than rendering as absent. admin_index now sets
    it to None; the real count arrives with the request queue.
    
    Both are the same mistake: a template written against fields the handler does
    not supply. Checked the rest of keys.ezt and admin.ezt against pages.py and
    these were the only two.
---
 pages.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pages.py b/pages.py
index 95351f4..66aee63 100644
--- a/pages.py
+++ b/pages.py
@@ -852,6 +852,9 @@ async def admin_index(result):
     """
     if not result.is_site_admin:
         raise AuthzError("Admin is limited to site admins.")
+    # ezt's [if-any] tests truthiness but still requires the name to exist.
+    # None renders the badge away; the real count arrives with the request queue.
+    result.pending_count = None
     return result
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org