You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/09/11 11:40:44 UTC
[GitHub] [yunikorn-core] lowc1012 opened a new pull request, #436: [YUNIKORN-1086] expose reservation information in the node rest response
lowc1012 opened a new pull request, #436:
URL: https://github.com/apache/yunikorn-core/pull/436
### What is this PR for?
expose reservation information in the node rest response
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
[YUNIKORN-1086](https://issues.apache.org/jira/browse/YUNIKORN-1086)
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #436: [YUNIKORN-1086] expose reservation information in the node rest response
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #436:
URL: https://github.com/apache/yunikorn-core/pull/436#issuecomment-1242946564
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/436?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#436](https://codecov.io/gh/apache/yunikorn-core/pull/436?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6685019) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/3e6942ff41a99c0a0f788074cdceebeea90c8230?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e6942f) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 72.35% 72.35%
=======================================
Files 65 65
Lines 9559 9561 +2
=======================================
+ Hits 6916 6918 +2
Misses 2405 2405
Partials 238 238
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.47% <100.00%> (+0.07%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #436: [YUNIKORN-1086] expose reservation information in the node rest response
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #436: [YUNIKORN-1086] expose reservation information in the node rest response
URL: https://github.com/apache/yunikorn-core/pull/436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org