[GitHub] [accumulo] keith-turner commented on a change in pull request #2432: Modified ThreadPools to conditionally register metrics

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #2432:
URL: https://github.com/apache/accumulo/pull/2432#discussion_r792780757



##########
File path: core/src/main/java/org/apache/accumulo/core/util/threads/ThreadPools.java
##########
@@ -104,81 +104,86 @@ public static void resizePool(final ThreadPoolExecutor pool, final AccumuloConfi
    */
   @SuppressWarnings("deprecation")
   public static ExecutorService createExecutorService(final AccumuloConfiguration conf,
-      final Property p) {
+      final Property p, boolean emitThreadPoolMetrics) {

Review comment:
       Could add some javadoc for this param like the following
   
   ```java
   @param emitThreadPoolMetrics When set to true will emit metrics and register the metrics in a static registry.  After the thread pool is deleted, there will still be metrics objects related to it in the static registry.  There is no way to clean these left over objects up therefore its recommened that this option only be set true for long lived thread pools.  Creating lots of short lived thread pools and registering them can lead to out of memory errors over long time periods.  
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org