You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/30 23:03:34 UTC

[GitHub] [kafka] ijuma opened a new pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5

ijuma opened a new pull request #9231:
URL: https://github.com/apache/kafka/pull/9231


   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5 and mockito

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9231:
URL: https://github.com/apache/kafka/pull/9231#issuecomment-688912021


   Unrelated flaky failures:
   
   ```
   Build / JDK 15 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
   Build / JDK 8 / kafka.api.PlaintextAdminIntegrationTest.testConsumerGroups
   Build / JDK 8 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5 and mockito

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9231:
URL: https://github.com/apache/kafka/pull/9231#discussion_r480023644



##########
File path: tools/src/test/java/org/apache/kafka/trogdor/coordinator/CoordinatorTest.java
##########
@@ -62,17 +62,18 @@
 import java.util.List;
 import java.util.Optional;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotEquals;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.fail;
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
+@Tag("integration")

Review comment:
       This test is much slower than the rest in `tools`, so I think it makes sense to mark it as `integration`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5 and mockito

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #9231:
URL: https://github.com/apache/kafka/pull/9231


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5 and mockito

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9231:
URL: https://github.com/apache/kafka/pull/9231#issuecomment-690779853


   Rebased to fix a trivial conflict. JDK 11 and JDK 8 builds passed, JDK 15 failed with 2 unrelated flaky test failures:
   
   > kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
   > kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
   > kafka.server.DynamicBrokerConfigTest.testPasswordConfigEncoderSecretChange


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org