You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/16 01:10:50 UTC
[GitHub] [incubator-superset] michellethomas opened a new pull request
#7047: Adding a warning message when saving title from explore
michellethomas opened a new pull request #7047: Adding a warning message when saving title from explore
URL: https://github.com/apache/incubator-superset/pull/7047
It's not super clear that editing the title overrides the chart. If you are trying to create a new chart by changing the params of an existing chart and you edit the title before "saving as" a new chart, you'll save over the existing chart. This adds a warning message when a title change will save over the existing chart.
The cancel action reverts the title back to the previously saved title.
Tested by
Testing save and cancel on an existing chart
Testing editing the title on a new chart (with no popup)
Testing editing title on dashboard chart (with no popup)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org