Re: [PR] Support AWS InternalError code retries (druid)

["Akshat-Jain (via GitHub)" <gi...@apache.org>]

Akshat-Jain commented on code in PR #18720:
URL: https://github.com/apache/druid/pull/18720#discussion_r2497801612


##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3Utils.java:
##########
@@ -96,6 +96,10 @@ public boolean apply(Throwable e)
         // This can happen sometimes when AWS isn't able to obtain the credentials for some service:
         // https://github.com/aws/aws-sdk-java/issues/2285
         return true;
+      } else if (e instanceof AmazonS3Exception && e.getMessage().contains("InternalError")) {
+        // This can happen sometimes when AWS returns a 200 response with internal error message
+        // https://repost.aws/knowledge-center/s3-resolve-200-internalerror

Review Comment:
   This link also suggests `SlowDown` keyword might need similar behaviour, shall we add that too?
   
   Quoting from the link:
   > A 200 response with InternalError or SlowDown is similar to a 5xx error. Because Amazon S3 is a distributed system, it's normal to see a small percentage of 200 internal errors. It's a best practice to retry these requests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org