You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/15 00:21:06 UTC
[GitHub] cckellogg commented on a change in pull request #1064: Allow topic metrics to be exported to prometheus optionally.
cckellogg commented on a change in pull request #1064: Allow topic metrics to be exported to prometheus optionally.
URL: https://github.com/apache/incubator-pulsar/pull/1064#discussion_r161415686
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/AggregatedNamespaceStats.java
##########
@@ -46,6 +46,39 @@
public Map<String, AggregatedReplicationStats> replicationStats = new HashMap<>();
+ void updateStats(TopicStats stats) {
+ topicsCount++;
+
+ subscriptionsCount += stats.subscriptionsCount;
+ producersCount += stats.producersCount;
+ consumersCount += stats.consumersCount;
+
+ rateIn += stats.rateIn;
+ rateOut += stats.rateOut;
+ throughputIn += stats.throughputIn;
+ throughputOut += stats.throughputOut;
+
+ storageSize += stats.storageSize;
+
+ storageWriteRate = stats.storageWriteRate;
Review comment:
@merlimat why are the storage write and read rate "="?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services