You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by jb...@apache.org on 2017/09/06 08:00:17 UTC

[1/2] karaf git commit: Primitives should not be boxed just for String conversion

Repository: karaf
Updated Branches:
  refs/heads/master 1e5352271 -> aaa3ed70f


Primitives should not be boxed just for String conversion

Signed-off-by: Aurélien Pupier <ap...@redhat.com>


Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/9b9dd794
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/9b9dd794
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/9b9dd794

Branch: refs/heads/master
Commit: 9b9dd7947577dec377808344e78736988f7e8428
Parents: 1e53522
Author: Aurélien Pupier <ap...@redhat.com>
Authored: Tue Sep 5 16:05:37 2017 +0200
Committer: Jean-Baptiste Onofré <jb...@apache.org>
Committed: Wed Sep 6 09:42:09 2017 +0200

----------------------------------------------------------------------
 .../main/java/org/apache/karaf/instance/main/Execute.java |  2 +-
 .../java/org/apache/karaf/shell/ssh/SshServerAction.java  |  2 +-
 .../java/org/apache/karaf/webconsole/gogo/Terminal.java   | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/karaf/blob/9b9dd794/instance/src/main/java/org/apache/karaf/instance/main/Execute.java
----------------------------------------------------------------------
diff --git a/instance/src/main/java/org/apache/karaf/instance/main/Execute.java b/instance/src/main/java/org/apache/karaf/instance/main/Execute.java
index f7feda4..9b2db09 100644
--- a/instance/src/main/java/org/apache/karaf/instance/main/Execute.java
+++ b/instance/src/main/java/org/apache/karaf/instance/main/Execute.java
@@ -163,7 +163,7 @@ public class Execute {
         if (exitAllowed) {
             System.exit(rc);
         } else {
-            throw new RuntimeException("" + rc);
+            throw new RuntimeException(Integer.toString(rc));
         }
     }
 

http://git-wip-us.apache.org/repos/asf/karaf/blob/9b9dd794/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/SshServerAction.java
----------------------------------------------------------------------
diff --git a/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/SshServerAction.java b/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/SshServerAction.java
index 74ee25a..8c08783 100644
--- a/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/SshServerAction.java
+++ b/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/SshServerAction.java
@@ -65,7 +65,7 @@ public class SshServerAction implements Action
         server.getProperties().put(SshServer.IDLE_TIMEOUT, Long.toString(idleTimeout));
         
         // nio-workes
-        server.getProperties().put(SshServer.NIO_WORKERS, new Integer(nioWorkers).toString());
+        server.getProperties().put(SshServer.NIO_WORKERS, Integer.toString(nioWorkers));
         
         // welcome banner
         if (welcomeBanner != null) {

http://git-wip-us.apache.org/repos/asf/karaf/blob/9b9dd794/webconsole/gogo/src/main/java/org/apache/karaf/webconsole/gogo/Terminal.java
----------------------------------------------------------------------
diff --git a/webconsole/gogo/src/main/java/org/apache/karaf/webconsole/gogo/Terminal.java b/webconsole/gogo/src/main/java/org/apache/karaf/webconsole/gogo/Terminal.java
index deb787e..aef58d6 100644
--- a/webconsole/gogo/src/main/java/org/apache/karaf/webconsole/gogo/Terminal.java
+++ b/webconsole/gogo/src/main/java/org/apache/karaf/webconsole/gogo/Terminal.java
@@ -1025,7 +1025,7 @@ public class Terminal {
         String prefix = "";
         if (p.length() > 0) {
             if (p.charAt(0) >= '<' && p.charAt(0) <= '?') {
-                prefix = "" + p.charAt(0);
+                prefix = Character.toString(p.charAt(0));
                 p = p.substring(1);
             }
         }
@@ -1710,14 +1710,14 @@ public class Terminal {
                 vt100_keyfilter_escape = true;
             } else if (c == 127) {
                 if (vt100_mode_backspace) {
-                    o += (char) 8;
+                    o += Integer.toString(8);
                 } else {
-                    o += (char) 127;
+                    o += Integer.toString(127);
                 }
             } else {
-                o += c;
+                o += Integer.toString(c);
                 if (vt100_mode_lfnewline && c == 13) {
-                    o += (char) 10;
+                    o += Integer.toString(10);
                 }
             }
         }


[2/2] karaf git commit: This closes #345

Posted by jb...@apache.org.
This closes #345


Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/aaa3ed70
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/aaa3ed70
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/aaa3ed70

Branch: refs/heads/master
Commit: aaa3ed70f2d6a38c3247dab7363c12078d038f3e
Parents: 1e53522 9b9dd79
Author: Jean-Baptiste Onofré <jb...@apache.org>
Authored: Wed Sep 6 10:00:13 2017 +0200
Committer: Jean-Baptiste Onofré <jb...@apache.org>
Committed: Wed Sep 6 10:00:13 2017 +0200

----------------------------------------------------------------------
 .../main/java/org/apache/karaf/instance/main/Execute.java |  2 +-
 .../java/org/apache/karaf/shell/ssh/SshServerAction.java  |  2 +-
 .../java/org/apache/karaf/webconsole/gogo/Terminal.java   | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------