[jira] [Commented] (FLINK-3729) Several SQL tests fail on Windows OS

["Stefano Baghino (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235391#comment-15235391 ] 

Stefano Baghino commented on FLINK-3729:
----------------------------------------

Perhaps the {{Table.explain(boolean)}} method could use {{System.lineSeparator()}} instead of hard-coded UNIX newlines ({{\n}}) when building the explain string ({{org.apache.flink.api.table.Table.scala:286}}). Would that work?

> Several SQL tests fail on Windows OS
> ------------------------------------
>
>                 Key: FLINK-3729
>                 URL: https://issues.apache.org/jira/browse/FLINK-3729
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API
>    Affects Versions: 1.0.1
>            Reporter: Chesnay Schepler
>
> The Table API SqlExplain(Test/ITCase) fail categorically on Windows due to different line-endings. These tests generate an string representation of an abstract syntax tree; problem is there is a difference in line-endings.
> The expected ones contain LF, the actual one CRLF.
> The tests should be either changed to either
> * include CRLF line-endings in the expected string when run on windows
> * always use LF line-endings regardless of OS
> * use a compare method that is aware of this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)