You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nchammas <gi...@git.apache.org> on 2014/08/29 18:19:55 UTC
[GitHub] spark pull request: [Docs] SQL doc formatting and typo fixes
GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/2201
[Docs] SQL doc formatting and typo fixes
Code fencing with triple-backticks doesn’t seem to work like it does on GitHub. Newlines are lost. Instead, use 4-space indent to format small code blocks.
Nested bullets need 2 leading spaces, not 1.
Spellcheck!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nchammas/spark sql-doc-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2201
----
commit 3b26c8d4df4f106679f6724ae5aa1eb8f7582d90
Author: nchammas <ni...@gmail.com>
Date: 2014-08-26T18:22:55Z
[Spark QA] Link to console output on test time out
When tests time out we should link to the Jenkins console output for easy review. We already do this for when tests start or complete normally.
Here's [a recent example](https://github.com/apache/spark/pull/2109#issuecomment-53374032) of where this would be helpful.
commit 5195e0c037a50f5eba9fd65648e9f3d3fc668484
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-08-29T16:16:28Z
[Docs] SQL doc formatting and typo fixes
Code fencing with triple-backticks doesn’t seem to work like it does on
GitHub. Newlines are lost.
Nested bullets need 2 leading spaces, not 1.
Spellcheck!
commit 873f889372c8ffb57fd122b5f91a16ee47227392
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-08-29T16:17:21Z
[Docs] fix skip-api flag
Comment says “skip generating API docs”, so the flag that follows it
should actually do that.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] SQL doc formatting and typo fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2201
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] SQL doc formatting and typo fixes
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2201#issuecomment-53898328
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19483/consoleFull) for PR 2201 at commit [`873f889`](https://github.com/apache/spark/commit/873f889372c8ffb57fd122b5f91a16ee47227392).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] SQL doc formatting and typo fixes
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2201#issuecomment-53905163
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19483/consoleFull) for PR 2201 at commit [`873f889`](https://github.com/apache/spark/commit/873f889372c8ffb57fd122b5f91a16ee47227392).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] SQL doc formatting and typo fixes
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2201#issuecomment-53936750
Thanks Nick! This is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] SQL doc formatting and typo fixes
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2201#discussion_r16906698
--- Diff: dev/run-tests-jenkins ---
@@ -138,7 +138,7 @@ function post_message () {
test_result="$?"
if [ "$test_result" -eq "124" ]; then
- fail_message="**Tests timed out** after a configured wait of \`${TESTS_TIMEOUT}\`."
+ fail_message="**[Tests timed out](${BUILD_URL}consoleFull)** after a configured wait of \`${TESTS_TIMEOUT}\`."
--- End diff --
Dunno why this diff shows here since [this file already has that change](https://github.com/apache/spark/blob/27df6ce6a2e6ba2142329f35e1670da184cb384c/dev/run-tests-jenkins#L141).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org