You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/11 12:08:31 UTC

[GitHub] [airflow] kaxil opened a new pull request #18886: Insert Apache License in ``airflow/www/static/robots.txt``

kaxil opened a new pull request #18886:
URL: https://github.com/apache/airflow/pull/18886


   The License Header was missing
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #18886: Ignore License check in ``airflow/www/static/robots.txt``

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18886:
URL: https://github.com/apache/airflow/pull/18886


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #18886: Insert Apache License in ``airflow/www/static/robots.txt``

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18886:
URL: https://github.com/apache/airflow/pull/18886#issuecomment-939981224


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #18886: Insert Apache License in ``airflow/www/static/robots.txt``

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18886:
URL: https://github.com/apache/airflow/pull/18886#issuecomment-939988636


   https://www.apache.org/legal/src-headers.html#faq-exceptions
   
   > A file without any degree of creativity in either its literal elements or its structure is not protected by copyright law; therefore, such a file does not require a license header. If in doubt about the extent of the file's creativity, add the license header to the file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #18886: Insert Apache License in ``airflow/www/static/robots.txt``

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #18886:
URL: https://github.com/apache/airflow/pull/18886#issuecomment-939991400


   > I think this one should be speical cased and not require a license header -- it's not guaranteed that all consumers of this will ignore comments (it's not a very well specified format) so I think in this case an exception is better than a license
   
   Agreed, updated the PR to add the files to `.rat_excludes` instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org