You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/04/23 11:52:04 UTC
[jira] [Commented] (HBASE-21451) The way we maintain the
lastestPaths in ReplicationSourceManager is broken when sync replication is
used
[ https://issues.apache.org/jira/browse/HBASE-21451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824038#comment-16824038 ]
Hudson commented on HBASE-21451:
--------------------------------
Results for branch master
[build #954 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/954/]: (x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/954//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/954//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/954//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> The way we maintain the lastestPaths in ReplicationSourceManager is broken when sync replication is used
> --------------------------------------------------------------------------------------------------------
>
> Key: HBASE-21451
> URL: https://issues.apache.org/jira/browse/HBASE-21451
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21451-v1.patch, HBASE-21451-v1.patch, HBASE-21451.patch
>
>
> Here is the problematic code
> {code}
> // Add to latestPaths
> Iterator<Path> iterator = latestPaths.iterator();
> while (iterator.hasNext()) {
> Path path = iterator.next();
> if (path.getName().contains(logPrefix)) {
> iterator.remove();
> break;
> }
> }
> this.latestPaths.add(newLog);
> {code}
> Here we just use contains, but for sync replication wal group, it just adds something after the default prefix for regionserver, so the code will be broken...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)