You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "milenkovicm (via GitHub)" <gi...@apache.org> on 2025/11/14 15:24:29 UTC

[PR] fix: Disable table name normalisation as default behaviour [datafusion]

milenkovicm opened a new pull request, #18708:
URL: https://github.com/apache/datafusion/pull/18708

   ## Which issue does this PR close?
   
   - Closes #18675.
   
   ## Rationale for this change
   
   There are cases for which case sensitive column names and table references are needed, so having forced `to_ascii_lowercase`  for  names breaks support for them. 
   
   `datafusion.sql_parser.enable_ident_normalization=false` will help with column names but table names and few other things will be converted to lowercase, or not (as described in the bug)
   
   This is potentially VERY BREAKING change, it disables forced `to_ascii_lowercase` for table reference and columns, as behaviour was hardcoded. 
   
   ## What changes are included in this PR?
   
   - disable forced to lowercase conversion for table ref and columns 
   - test to verify bug 
   
   ## Are these changes tested?
   
   yes
   
   ## Are there any user-facing changes?
   
   yes, 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: Disable table name normalisation as default behaviour [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm closed pull request #18708: fix: Disable table name normalisation as default behaviour 
URL: https://github.com/apache/datafusion/pull/18708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org