You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/19 01:59:15 UTC

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #7049: [IOTDB-4020] Use canonical path when recovering wal

JackieTien97 commented on code in PR #7049:
URL: https://github.com/apache/iotdb/pull/7049#discussion_r949733310


##########
server/src/main/java/org/apache/iotdb/db/wal/recover/WALNodeRecoverTask.java:
##########
@@ -199,9 +199,8 @@ private void recoverInfoFromCheckpoints() {
     for (MemTableInfo memTableInfo : memTableId2Info.values()) {
       firstValidVersionId = Math.min(firstValidVersionId, memTableInfo.getFirstFileVersionId());
 
-      File tsFile = new File(memTableInfo.getTsFilePath());
       UnsealedTsFileRecoverPerformer recoverPerformer =
-          walRecoverManger.removeRecoverPerformer(tsFile.getAbsolutePath());
+          walRecoverManger.removeRecoverPerformer(new File(memTableInfo.getTsFilePath()));

Review Comment:
   You should change the filePath in MemtableInfo to canonical path which is in `TsFileResource.getTsFilePath()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org