[GitHub] rafaelweingartner commented on a change in pull request #2574: [CLOUDSTACK-5235] ask users old password when they are executing a password update

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2574: [CLOUDSTACK-5235] ask users old password when they are executing a password update
URL: https://github.com/apache/cloudstack/pull/2574#discussion_r182035508
 
 

 ##########
 File path: api/src/main/java/com/cloud/user/AccountService.java
 ##########
 @@ -23,53 +23,28 @@
 import org.apache.cloudstack.acl.SecurityChecker.AccessType;
 import org.apache.cloudstack.api.command.admin.user.GetUserKeysCmd;
 import org.apache.cloudstack.api.command.admin.user.RegisterCmd;
+import org.apache.cloudstack.api.command.admin.user.UpdateUserCmd;
 
 import com.cloud.domain.Domain;
 import com.cloud.exception.PermissionDeniedException;
 import com.cloud.offering.DiskOffering;
 import com.cloud.offering.ServiceOffering;
 
-
 public interface AccountService {
 
     /**
      * Creates a new user and account, stores the password as is so encrypted passwords are recommended.
-     *
 
 Review comment:
   Well, I do like Java documentation; however, in this case, the use of `@param` does not bring benefits. I mean, if each one of the parameters was fully described it would be ok, but that is not what happened here. That is why I removed them.
   
   I am sorry Nitin, but I would rather not document those parameters. Instead, we should get rid of these methods with a lot of parameters. My changes affect only the `updateUser` method (I already refactored that whole method). Afterwards, I executed a cleanup in the classes that I had modified some code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services