You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/03/06 14:02:47 UTC

Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70137/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
    https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
-------

Made volume gid manager allocate & deallocate gid to non-shared PV.


Diffs
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 08449e269b550ba41f63b909ffbd5f7a7a83e32b 
  src/slave/slave.cpp f9b58175ad5433bdfc15a312dfce6e972dea7fa3 


Diff: https://reviews.apache.org/r/70137/diff/1/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70137/#review213543
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On March 6, 2019, 6:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70137/
> -----------------------------------------------------------
> 
> (Updated March 6, 2019, 6:03 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-8813
>     https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made volume gid manager allocate & deallocate gid to non-shared PV.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 08449e269b550ba41f63b909ffbd5f7a7a83e32b 
>   src/slave/slave.cpp f9b58175ad5433bdfc15a312dfce6e972dea7fa3 
> 
> 
> Diff: https://reviews.apache.org/r/70137/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70137/
-----------------------------------------------------------

(Updated March 7, 2019, 4:55 p.m.)


Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-9641
    https://issues.apache.org/jira/browse/MESOS-9641


Repository: mesos


Description
-------

Made volume gid manager allocate & deallocate gid to non-shared PV.


Diffs
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 08449e269b550ba41f63b909ffbd5f7a7a83e32b 
  src/slave/slave.cpp f9b58175ad5433bdfc15a312dfce6e972dea7fa3 


Diff: https://reviews.apache.org/r/70137/diff/1/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70137/
-----------------------------------------------------------

(Updated March 6, 2019, 10:03 p.m.)


Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8813
    https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
-------

Made volume gid manager allocate & deallocate gid to non-shared PV.


Diffs
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 08449e269b550ba41f63b909ffbd5f7a7a83e32b 
  src/slave/slave.cpp f9b58175ad5433bdfc15a312dfce6e972dea7fa3 


Diff: https://reviews.apache.org/r/70137/diff/1/


Testing
-------


Thanks,

Qian Zhang