You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/07/31 11:48:21 UTC

[GitHub] [spark] LuciferYang opened a new pull request, #42240: [SPARK-44608][SQL] Remove unused definitions from `DataTypeExpression`

LuciferYang opened a new pull request, #42240:
URL: https://github.com/apache/spark/pull/42240

   ### What changes were proposed in this pull request?
   https://github.com/apache/spark/pull/41559 have defined some `DataTypeExpression` but did not use, such as `ByteTypeExpression`,  `ShortTypeExpression`, etc. This pr cleans them up and we can define them when we really need.
   
   
   ### Why are the changes needed?
   Code cleanup
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GitHub Actions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #42240: [SPARK-44608][SQL] Remove unused definitions from `DataTypeExpression`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42240:
URL: https://github.com/apache/spark/pull/42240#issuecomment-1661073583

   @amaliujia These are some unused and untested code, and they are public. If they are released in Spark 3.5, we have an obligation to continue maintaining them and ensuring compatibility, even if they will never be used, which itself is a risk. So I prefer to define when there are actual needs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #42240: [SPARK-44608][SQL] Remove unused definitions from `DataTypeExpression`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42240:
URL: https://github.com/apache/spark/pull/42240#issuecomment-1659904592

   @amaliujia Can we temporarily delete this useless definitions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] amaliujia commented on pull request #42240: [SPARK-44608][SQL] Remove unused definitions from `DataTypeExpression`

Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #42240:
URL: https://github.com/apache/spark/pull/42240#issuecomment-1660624405

   @LuciferYang we added this for the completeness of DataTypeExpressions. It is just natural that each data type has its DataTypeExpression. 
   
   Does it cause any problem so far?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org