[GitHub] [airflow] ashb edited a comment on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions modification via UI do not persist

[GitBox <gi...@apache.org>]

ashb edited a comment on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions modification via UI do not persist
URL: https://github.com/apache/airflow/pull/4118#issuecomment-469801650
 
 
   @feng-tao to continue the discussion from https://github.com/apache/airflow/pull/4569#issuecomment-469796095 as it applies to this PR.
   
   On a fresh install the `all_dags` view menu isn't created until _after_ the roles are created, so no roles will ever get the `can_dag_*` permission applied to them, except for admin which gets all permissions:
   
   ```python
           # Create default user role.
           for config in ROLE_CONFIGS:
               role = config['role']
               vms = config['vms']
               perms = config['perms']
               self.init_role(role, vms, perms)
           self.create_custom_dag_permission_view()
   ```
   
   Moving the `create_custom_dag_permission_view()` call to before/splitting the all_dags VM out  would work for new install, but wouldn't help users upgrading.
   
   Given this is now in a released version (1.10.2) I think we need to come up with a migration-style approach to add new roles to existing roles when we add new permissions. I'll probably create a Jira ticket

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services