[GitHub] [airflow] josh-fell commented on a diff in pull request #30031: Clarify optional parameters in Airbyte docstrings

["josh-fell (via GitHub)" <gi...@apache.org>]

josh-fell commented on code in PR #30031:
URL: https://github.com/apache/airflow/pull/30031#discussion_r1132917248


##########
airflow/providers/airbyte/operators/airbyte.py:
##########
@@ -53,10 +54,10 @@ def __init__(
         self,
         connection_id: str,
         airbyte_conn_id: str = "airbyte_default",
-        asynchronous: bool | None = False,
+        asynchronous: bool = False,
         api_version: str = "v1",
         wait_seconds: float = 3,
-        timeout: float | None = 3600,
+        timeout: float = 3600,

Review Comment:
   Cleaned up some typing as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org