You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/08 17:15:46 UTC

[GitHub] [iceberg] samredai commented on pull request #4062: Docs: add new site markdown files

samredai commented on pull request #4062:
URL: https://github.com/apache/iceberg/pull/4062#issuecomment-1032861386


   All of the markdown files that contain content can just have the license headers added right below the hugo front matter and it will be detected by the license check. That's also true for the `_index.md` files but hugo will then consider that a file with content and there are other implications like the section titles in the left nav will be hyperlinked but show an empty page.
   
   We should be able to solve this by adding `*_index.md` to the [.rat-excludes](https://github.com/apache/iceberg/blob/master/dev/.rat-excludes) file. I think this is ok since those don't have any content in them anyway and just hold the section header names or an external link. Then adding the license header below the `---` front matter will allow those to pass the check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org