[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #73: Update sandbox component 'tf-ner-poc' to be compatible with latest opennlp-tools release

["rzo1 (via GitHub)" <gi...@apache.org>]

rzo1 commented on code in PR #73:
URL: https://github.com/apache/opennlp-sandbox/pull/73#discussion_r1083850500


##########
tf-ner-poc/src/test/java/org/apache/opennlp/namefinder/PredictTest.java:
##########
@@ -1,31 +1,39 @@
 package org.apache.opennlp.namefinder;
 
-import java.io.IOException;
+import org.junit.Ignore;
+import org.junit.Test;
 
 import opennlp.tools.util.Span;
 
+import java.io.IOException;
+import java.nio.file.Path;
+
 public class PredictTest {
 
-  public static void main(String[] args) throws IOException {
+  @Test @Ignore
+  // TODO This test is not platform neutral and, for instance, fails with:
+  //  "Cannot find TensorFlow native library for OS: darwin, architecture: aarch64"
+  //  We need JUnit 5 in the sandbox to circumvent this, so it can be run in supported environments

Review Comment:
   Sadly, GH action has no M1/M2 support atm: https://github.com/actions/runner-images/issues/2187
   
   I think, that Infra has aarch64 node available on Jenkins, so maybe we can add a dedicataed build job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org