[jira] [Commented] (IMPALA-8879) Upgrade bootstrap.js

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921166#comment-16921166 ] 

ASF subversion and git services commented on IMPALA-8879:
---------------------------------------------------------

Commit b14848151b5e47ab0ca0f4e8a11add0d6e6b7b64 in impala's branch refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b148481 ]

IMPALA-8879: upgrade bootstrap for debug page to 4.3.1

Also upgrade DataTables to 1.10.18 at the same time..

They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.

Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).

I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
  breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
  appear similar to the old graph.
* Added styling for <pre> to get box around text.

Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.

Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Reviewed-on: http://gerrit.cloudera.org:8080/14119
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Upgrade bootstrap.js
> --------------------
>
>                 Key: IMPALA-8879
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8879
>             Project: IMPALA
>          Issue Type: Task
>          Components: Frontend
>    Affects Versions: Impala 3.3.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> The version we're using is quite out-of-date.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org