You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2023/07/26 18:12:07 UTC
[GitHub] [daffodil-vscode] shanedell opened a new pull request, #716: Multiple svelte updates:
shanedell opened a new pull request, #716:
URL: https://github.com/apache/daffodil-vscode/pull/716
Multiple svelte updates:
- Merge svelte package.json with root package.json.
- Move svelete code to be built/watched using webpack instead of rollup.
- Remove svelete unneeded files like .prettierrc, yarn.lock, etc.
- Update root to properly lint svelte source.
Closes #709
Closes #710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #716: Multiple svelte updates:
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#discussion_r1277732171
##########
package.json:
##########
@@ -56,20 +56,31 @@
"xdg-app-paths": "8.3.0"
},
"devDependencies": {
+ "@tsconfig/svelte": "^3.0.0",
"@types/glob": "^8.0.0",
"@types/mocha": "^10.0.1",
"@types/node": "^18.15.3",
"@types/vscode": "^1.60.2",
+ "@types/vscode-webview": "^1.57.1",
"@vscode/debugadapter-testsupport": "1.59.0",
"@vscode/test-electron": "2.1.5",
"@vscode/vsce": "2.19.0",
"chai": "^4.3.7",
"concurrently": "^7.0.0",
"copy-webpack-plugin": "^11.0.0",
+ "css-loader": "^6.8.1",
+ "css-minimizer-webpack-plugin": "^5.0.1",
"glob": "8.0.3",
+ "mini-css-extract-plugin": "^2.7.6",
"mocha": "10.2.0",
"prettier": "2.8.8",
+ "prettier-plugin-svelte": "^2.9.0",
"run-func": "^3.0.0",
+ "sass": "^1.57.1",
+ "svelte": "^3.55.0",
Review Comment:
Some of these deps will be updated (for instance, we're using Svelte 4 now instead of 3). In the v1.3.1 data editor branch that we've been working on has some package updates and things we'll need to port over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #716: Multiple svelte updates:
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on code in PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#discussion_r1276333548
##########
src/svelte/webpack.config.js:
##########
Review Comment:
Yeah I also tried to implement `webpack` modifications to resolve some of the long `import` file paths but ran into the same issue. Nothing being imported was resolvable. I was very confused ha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #716: Multiple svelte updates:
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#issuecomment-1655948341
No worries, this is already a nice consolidation. If the webpack consolidation comes at the expense of a bunch of additional complexity, then it's not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #716: Multiple svelte updates:
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#discussion_r1276290689
##########
src/svelte/webpack.config.js:
##########
Review Comment:
@stricklandrbls I believe @scholarsmate mentioned he took a stab at the `webpack` for svelte. But he also mentioned it didn't seem to fully function as desired and had asked me too to look into it and see if I could get it working. So I guess it would depend on what @scholarsmate thinks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #716: Multiple svelte updates:
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#discussion_r1277735555
##########
package.json:
##########
@@ -56,20 +56,31 @@
"xdg-app-paths": "8.3.0"
},
"devDependencies": {
+ "@tsconfig/svelte": "^3.0.0",
"@types/glob": "^8.0.0",
"@types/mocha": "^10.0.1",
"@types/node": "^18.15.3",
"@types/vscode": "^1.60.2",
+ "@types/vscode-webview": "^1.57.1",
"@vscode/debugadapter-testsupport": "1.59.0",
"@vscode/test-electron": "2.1.5",
"@vscode/vsce": "2.19.0",
"chai": "^4.3.7",
"concurrently": "^7.0.0",
"copy-webpack-plugin": "^11.0.0",
+ "css-loader": "^6.8.1",
+ "css-minimizer-webpack-plugin": "^5.0.1",
"glob": "8.0.3",
+ "mini-css-extract-plugin": "^2.7.6",
"mocha": "10.2.0",
"prettier": "2.8.8",
+ "prettier-plugin-svelte": "^2.9.0",
"run-func": "^3.0.0",
+ "sass": "^1.57.1",
+ "svelte": "^3.55.0",
Review Comment:
Yeah would be probably be something you would want to do in that branch to make sure it works with all the new stuff thats in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls merged pull request #716: Multiple svelte updates:
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls merged PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #716: Multiple svelte updates:
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on code in PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#discussion_r1276270006
##########
src/svelte/webpack.config.js:
##########
Review Comment:
@scholarsmate @shanedell - There's currently a webpack config implemented in the [ctc-oss/implement-highlevel-svelte-components](https://github.com/ctc-oss/daffodil-vscode/tree/implement-highlevel-svelte-components) branch.
We may need to link up and determine which version to use or whether to merge / intersect the difference when the aforementioned branch is up for PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #716: Multiple svelte updates:
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#discussion_r1277730259
##########
src/svelte/webpack.config.js:
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+//@ts-check
+'use strict'
+
+//@ts-check
+/** @typedef {import('webpack').Configuration} WebpackConfig **/
+
+// const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin')
Review Comment:
If we're not using this, let's just remove the commented out code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on pull request #716: Multiple svelte updates:
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #716:
URL: https://github.com/apache/daffodil-vscode/pull/716#issuecomment-1655943015
> +1, looks good overall. Perhaps later we can merge together the `webpack.config.js` together and just have a single top-level one.
This might be possible but also possibly not because the way things are done to built the svelte stuff is slightly different that we do for the extension so that would have to looked into more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org